Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RopeBuilder's Default derive creates an invalid RopeBuilder #74

Closed
kirawi opened this issue Dec 3, 2022 · 1 comment
Closed

RopeBuilder's Default derive creates an invalid RopeBuilder #74

kirawi opened this issue Dec 3, 2022 · 1 comment

Comments

@kirawi
Copy link

kirawi commented Dec 3, 2022 •
edited
Loading

I noticed this in helix-editor/helix#4983. It looks like the cause is that the stack is not initialized with a single starting node.
@kirawi kirawi changed the title RopeBuilder RopeBuilder's Default derive creates an invalid RopeBuilder Dec 3, 2022
cessen added a commit that referenced this issue Dec 3, 2022
@cessen
Fix broken Default impl for RopeBuilder.
dfcac8b 
Fixes issue #74.
@cessen
Copy link
Owner

cessen commented Dec 3, 2022

Thanks for the report! And yup, that was exactly the problem. Fixed in dfcac8b.

@cessen cessen closed this as completed Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cessen @kirawi