Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When build with -buildmode=plugin, go complains asm error #54

Closed
MXWXZ opened this issue Aug 18, 2021 · 2 comments
Closed

When build with -buildmode=plugin, go complains asm error #54

MXWXZ opened this issue Aug 18, 2021 · 2 comments

Comments

@MXWXZ
Copy link

MXWXZ commented Aug 18, 2021

When imported and build with -buildmode=plugin or anything use dynamic link, go will throw

when dynamic linking, R15 is clobbered by a global variable access and is used here

ref: review src issue

PR posted, should just replaced with imm-value, seems no other side effect with that.
@MXWXZ MXWXZ mentioned this issue Aug 18, 2021
Closed
@AlexanderYastrebov AlexanderYastrebov mentioned this issue Aug 19, 2021
Merged
@cespare
Copy link
Owner

cespare commented Aug 20, 2021

I've started looking at this. I think there are other issues when using dynamic linking, not just R15.

First step is to get the tests running somehow under dynamic linking. This turns out to be fairly annoying (see golang/go#18814, golang/go#18729).

cespare added a commit that referenced this issue Aug 24, 2021
@cespare
Fix asm for dynamic linking
b2091fe 
R15 and CX are both clobbered under dynamic linking; avoid them.

Fixes #54
@cespare
Copy link
Owner

cespare commented Aug 24, 2021

I released v2.1.2 with the fix.

AlexanderYastrebov added a commit to zalando/skipper that referenced this issue Aug 24, 2021
@AlexanderYastrebov
Updates xxhash dependency version
892a819 
Fixes build failure on go 1.17 caused by cespare/xxhash#54

Signed-off-by: Alexander Yastrebov <[email protected]>
@AlexanderYastrebov AlexanderYastrebov mentioned this issue Aug 24, 2021
Merged
AlexanderYastrebov added a commit to zalando/skipper that referenced this issue Aug 24, 2021
@AlexanderYastrebov
Updates xxhash dependency version
15e28a8 
Fixes build failure on go 1.17 caused by cespare/xxhash#54

Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov added a commit to zalando/skipper that referenced this issue Aug 24, 2021
@AlexanderYastrebov
Updates xxhash dependency version (#1834)
c49e453 
Fixes build failure on go 1.17 caused by cespare/xxhash#54

Signed-off-by: Alexander Yastrebov <[email protected]>
klauspost added a commit to klauspost/compress that referenced this issue Sep 1, 2021
@klauspost
Upgrade xxhash
ffd4cdb 
Includes cespare/xxhash#54

Fixes #248
@klauspost klauspost mentioned this issue Sep 1, 2021
Merged
klauspost added a commit to klauspost/compress that referenced this issue Sep 1, 2021
@klauspost
Upgrade xxhash (#430)
d4a7d38 
Includes cespare/xxhash#54

Fixes #248
@antgamdia antgamdia mentioned this issue Sep 7, 2021
Merged
@zshi-redhat zshi-redhat mentioned this issue Sep 10, 2021
Merged
fedepaol added a commit to fedepaol/sriov-network-operator-1 that referenced this issue Sep 10, 2021
@fedepaol
Update github.com/cespare/xxhash/v2 to v2.1.2
fe6c75a 
github.com/cespare/xxhash/v2 v2.1.1 is incompatible with Go 1.17 (see cespare/xxhash#54)
Here we bump up the dependency to solve the issue.

Signed-off-by: Federico Paolinelli <[email protected]>
@fedepaol fedepaol mentioned this issue Sep 10, 2021
Merged
fedepaol added a commit to fedepaol/sriov-network-operator-1 that referenced this issue Sep 10, 2021
@fedepaol
Update github.com/cespare/xxhash/v2 to v2.1.2
a2013d1 
github.com/cespare/xxhash/v2 v2.1.1 is incompatible with Go 1.17 (see cespare/xxhash#54)
Here we bump up the dependency to solve the issue.

Signed-off-by: Federico Paolinelli <[email protected]>
fedepaol added a commit to fedepaol/sriov-network-operator-1 that referenced this issue Sep 10, 2021
@fedepaol
Update github.com/cespare/xxhash/v2 to v2.1.2
303abed 
github.com/cespare/xxhash/v2 v2.1.1 is incompatible with Go 1.17 (see cespare/xxhash#54)
Here we bump up the dependency to solve the issue.

Signed-off-by: Federico Paolinelli <[email protected]>
fedepaol added a commit to fedepaol/sriov-network-operator-1 that referenced this issue Sep 13, 2021
@fedepaol
Update github.com/cespare/xxhash/v2 to v2.1.2
01428a9 
github.com/cespare/xxhash/v2 v2.1.1 is incompatible with Go 1.17 (see cespare/xxhash#54)
Here we bump up the dependency to solve the issue.

Signed-off-by: Federico Paolinelli <[email protected]>
fedepaol added a commit to fedepaol/sriov-network-operator-1 that referenced this issue Sep 13, 2021
@fedepaol
Update github.com/cespare/xxhash/v2 to v2.1.2
c1edce4 
github.com/cespare/xxhash/v2 v2.1.1 is incompatible with Go 1.17 (see cespare/xxhash#54)
Here we bump up the dependency to solve the issue.

Signed-off-by: Federico Paolinelli <[email protected]>
SchSeba pushed a commit to SchSeba/sriov-network-operator that referenced this issue Sep 14, 2021
@fedepaol @SchSeba
Update github.com/cespare/xxhash/v2 to v2.1.2
a26a886 
github.com/cespare/xxhash/v2 v2.1.1 is incompatible with Go 1.17 (see cespare/xxhash#54)
Here we bump up the dependency to solve the issue.

Signed-off-by: Federico Paolinelli <[email protected]>
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/sriov-network-operator that referenced this issue Sep 14, 2021
@fedepaol
Update github.com/cespare/xxhash/v2 to v2.1.2
e0223e2 
github.com/cespare/xxhash/v2 v2.1.1 is incompatible with Go 1.17 (see cespare/xxhash#54)
Here we bump up the dependency to solve the issue.

Signed-off-by: Federico Paolinelli <[email protected]>
@manedurphy manedurphy mentioned this issue Sep 15, 2021
Closed
@zishen zishen mentioned this issue Sep 19, 2021
Closed
@dtrudg dtrudg mentioned this issue Sep 20, 2021
Closed
@zishen zishen mentioned this issue Sep 22, 2021
Closed
@aschmahmann aschmahmann mentioned this issue Oct 27, 2021
Merged
@aschmahmann aschmahmann mentioned this issue Nov 14, 2021
Closed
3 tasks
kraj added a commit to kraj/xxhash that referenced this issue Dec 1, 2021
@kraj
Fix asm for dynamic linking
8254a11 
R15 and CX are both clobbered under dynamic linking; avoid them.

Fixes cespare#54

Backport of cespare@e7a6b52

Signed-off-by: Khem Raj <[email protected]>
@denyeart denyeart mentioned this issue Dec 13, 2021
Closed
july2993 added a commit to july2993/freecache that referenced this issue Dec 15, 2021
@july2993
Use xxhash/v2
23e8f71 
to address:
cespare/xxhash#54
@siddharthlatest siddharthlatest mentioned this issue Dec 15, 2021
Closed
eh-steve pushed a commit to vivacitylabs/badger that referenced this issue Feb 20, 2022
Bump xxhash to v2 to fix cespare/xxhash#54
feb4358
eh-steve pushed a commit to vivacitylabs/badger that referenced this issue Feb 20, 2022
Bump xxhash to v2 to fix cespare/xxhash#54
803ab19
eh-steve pushed a commit to vivacitylabs/badger that referenced this issue Feb 21, 2022
Bump xxhash to v2 to fix cespare/xxhash#54
a9a303a
@siddharthlatest siddharthlatest mentioned this issue Mar 28, 2022
Closed
eh-steve pushed a commit to eh-steve/badger that referenced this issue Apr 4, 2022
Bump xxhash to v2 to fix cespare/xxhash#54
249ae29
eh-steve pushed a commit to eh-steve/badger that referenced this issue Apr 4, 2022
Bump xxhash to v2 to fix cespare/xxhash#54
f195b6c
eh-steve added a commit to eh-steve/badger that referenced this issue Apr 5, 2022
@eh-steve
Bump xxhash to v2 to fix cespare/xxhash#54
ba2c6a0
eh-steve pushed a commit to eh-steve/badger that referenced this issue Apr 5, 2022
Bump xxhash to v2 to fix cespare/xxhash#54
75c62e6
eh-steve added a commit to eh-steve/badger that referenced this issue Apr 5, 2022
@eh-steve
Bump xxhash to v2 to fix cespare/xxhash#54
d11a1d3
jarifibrahim pushed a commit to outcaste-io/badger that referenced this issue Apr 5, 2022
@eh-steve
Bump xxhash to v2 to fix cespare/xxhash#54 (#7)
ade7785
@chrismeyers chrismeyers mentioned this issue May 10, 2022
Closed
@mjungsbluth mjungsbluth mentioned this issue Jun 22, 2022
Merged
manishrjain pushed a commit to outcaste-io/outserv that referenced this issue Jul 6, 2022
@eh-steve
Bump xxhash to v2 to fix cespare/xxhash#54 (#7)
4fa8cfb
daveamit added a commit to daveamit/health that referenced this issue Jan 6, 2023
@daveamit
upgraded prom client to v1.14.0 because of cespare/xxhash#54
0c7a86d
@kailun-qin kailun-qin mentioned this issue Mar 7, 2023
Closed
@mangalaman93 mangalaman93 mentioned this issue Mar 18, 2023
Closed
@geissonator geissonator mentioned this issue Mar 24, 2023
Closed
geissonator added a commit to geissonator/etcd that referenced this issue Mar 24, 2023
@geissonator
xxhash: bump to v2.1.2
e99ee73 
There is a known issue in v2.1.1:

  cespare/xxhash#54

Fix that issue by bumping to the version with the fix.

This has been fixed in upstream etcd via the following:

  etcd-io@f0f77fc

But it was a pretty major upgrade so just take the one piece we need for
the etcd v3.5 release tag.

Signed-off-by: Andrew Geissler <[email protected]>
@geissonator geissonator mentioned this issue Mar 24, 2023
Closed
geissonator added a commit to geissonator/etcd that referenced this issue Mar 24, 2023
@geissonator
xxhash: bump to v2.1.2
c34f524 
There is a known issue in v2.1.1:

  cespare/xxhash#54

Fix that issue by bumping to the version with the fix.

This has been fixed in upstream etcd via the following:

  etcd-io@f0f77fc

But it was a pretty major upgrade so just take the one piece we need for
the etcd v3.5 release tag.

Signed-off-by: Andrew Geissler <[email protected]>
@hsanjuan hsanjuan mentioned this issue Apr 26, 2023
Closed
3 tasks
@ekopsy ekopsy mentioned this issue May 24, 2023
Closed
@bafflingbug bafflingbug mentioned this issue Sep 22, 2023
Closed
@sesposito sesposito mentioned this issue Dec 11, 2023
Merged
mangalaman93 pushed a commit to dgraph-io/ristretto that referenced this issue Dec 11, 2023
@sesposito
Upgrade xxhash dependency to v2.2.0 (#367)
231c676 
When using ristretto in a Go plugin it's currently failing to build due
to: cespare/xxhash#54, so this PR is simply
updating the dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cespare @MXWXZ