Only match entities not embedded in links

[staab]

Before this change, pasting njump links would trigger the entity regexp. This ensures only entities surrounded by a space or the beginning/end of a string will get matched.

[cesardeazevedo]

Yeah, this problem is very annoying, I also tried to do this exact approach you did but I ended up reverting it because of other issues it caused, I will do some more investigation before merging it.

[cesardeazevedo]

What do you think of

for (const match of text.matchAll(NEVENT_REGEX)) {
+  if (text[match.index - 1] !== '/') {
    try {
      const data = nip19.decode(match[2]).data as EventPointer
      const nevent = match[0]

      matches.push(createPasteRuleMatch(match, { ...data, nevent }))
    } catch (e) {
      continue
    }
+  }
}

[staab]

What kind of other issues did you run into? We could limit the scope of the regex ((?:\/) would be equivalent to the code you proposed above I think), but white-listing specific characters could turn into a game of whack-a-mole. If you want to go that route though, the only cases I can think of would be / and = in case the entity is in a query parameter.

[cesardeazevedo]

Pasting multiple nprofiles at once eats the space between them, doesn't happen with block nodes though

[staab]

Even if there's a space between the nprofiles in the copied text? Seems like a bug rather than a parser problem. I've run into lots of similar things working with tiptap/prosemirror. It's very hard to get the behavior exactly right.

[cesardeazevedo]

@staab Sorry for the delay, just coming back into this.

I just tried with (?<![\w./:?=]) and worked, with a lookbehind assertion the matched position stays the same.

Here's the issue with (?:^|\s)

pasting:

nostr:nprofile1qy88wumn8ghj7mn0wvhxcmmv9uq32amnwvaz7tmjv4kxz7fwv3sk6atn9e5k7tcprfmhxue69uhhyetvv9ujuem9w3skccne9e3k7mf0wccsqgxxvqas78x0a339m8qgkaf7fam5atmarne8dy3rzfd4l4x6w2qpncmfs8zh nostr:nprofile1qy88wumn8ghj7mn0wvhxcmmv9uq32amnwvaz7tmjv4kxz7fwv3sk6atn9e5k7tcprfmhxue69uhhyetvv9ujuem9w3skccne9e3k7mf0wccsqgxxvqas78x0a339m8qgkaf7fam5atmarne8dy3rzfd4l4x6w2qpncmfs8zh

Now with (?<![\w./:?=])

njump links

Let me know what you think.

[staab]

That makes sense, just pushed an update