Skip to content

Commit

Permalink
Goodbye python 2
Browse files Browse the repository at this point in the history
  • Loading branch information
@Lukasa
Lukasa committed Apr 5, 2020
1 parent 87836b3 commit 5efdd48
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
4 changes: 2 additions & 2 deletions README.rst
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ built-in function::
>>> import certifi

>>> certifi.where()
'/usr/local/lib/python2.7/site-packages/certifi/cacert.pem'
'/usr/local/lib/python3.7/site-packages/certifi/cacert.pem'

Or from the command line::

$ python -m certifi
/usr/local/lib/python2.7/site-packages/certifi/cacert.pem
/usr/local/lib/python3.7/site-packages/certifi/cacert.pem

Enjoy!

Expand Down
3 changes: 0 additions & 3 deletions setup.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,6 @@
'License :: OSI Approved :: Mozilla Public License 2.0 (MPL 2.0)',
'Natural Language :: English',
'Programming Language :: Python',
'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.6',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.3',
'Programming Language :: Python :: 3.4',
Expand Down

3 comments on commit 5efdd48

@dotlambda
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lukasa It would be nice if you could add python_requires='>=3.3' to setup.py.

@clefru
Copy link

@clefru clefru commented on 5efdd48 Jul 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give a rational why Python 2 support was removed? There is almost no code in this repo, and supporting two flavors of Python is not particularly difficult. While I understand people want to kill things off, there is a lot of legacy code that isn't just updated and lots of that code depends on the "requests" package. Not having an up2date certificate package underneath creates a security risk for lots of legacy code.

@stevenpackardblp
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 2.7 is EOL and no longer getting updates, so just using Python 2.7 is, in and of itself, a security risk for lots of legacy code.

Please sign in to comment.