Skip to content

Improve the documentation of how to change the release-next periodic tests#827

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
wallrj:release-process-fixes
Jan 28, 2022
Merged

Improve the documentation of how to change the release-next periodic tests#827
jetstack-bot merged 1 commit intocert-manager:masterfrom
wallrj:release-process-fixes

Conversation

@wallrj
Copy link
Member

@wallrj wallrj commented Jan 28, 2022

Commenting out or removing the file, as is currently recommended, breaks the Kubernetes Test Grid, so we change the interval instead.

…tests

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 28, 2022
@netlify
Copy link

netlify bot commented Jan 28, 2022

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: ee4f867

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/61f3b9e3a02e2b00089a8d29

😎 Browse the preview: https://deploy-preview-827--cert-manager-website.netlify.app/docs/contributing/release-process

@SgtCoDFish
Copy link
Member

[APPROVALNOTIFIER] This PR is NOT APPROVED

@wallrj you're not in the OWNERS file for the website! How on earth has that happened?! #828 should fix that :)

Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Good improvements, thanks!

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2022
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2022
@jetstack-bot jetstack-bot merged commit 56646c1 into cert-manager:master Jan 28, 2022
@wallrj wallrj deleted the release-process-fixes branch February 11, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants