Document the use of the HTTP01 Gateway API solver by maelvls · Pull Request #625 · cert-manager/website

maelvls · 2021-06-22T16:53:47Z

Preview: https://deploy-preview-625--cert-manager-website.netlify.app/docs/configuration/acme/http01/#configuring-the-http01-gateway-api-solver

This is the documentation for cert-manager/cert-manager#4276.

jetstack-bot · 2021-06-22T16:53:49Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

JoshVanL

Couple comments from me. Looks like this needs some kind of rebasing :)

content/en/docs/configuration/acme/http01/_index.md

netlify · 2021-08-04T12:30:15Z

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: eaefa68

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/61138ab369bd5d000984f808

😎 Browse the preview: https://deploy-preview-625--cert-manager-website.netlify.app

.gitattributes

content/en/docs/configuration/acme/http01/_index.md

Signed-off-by: Maël Valais <mael@vls.dev>

This is the feature gate name that was picked in cert-manager/cert-manager#4310. Signed-off-by: Maël Valais <mael@vls.dev>

maelvls · 2021-08-09T09:30:31Z

While writing this PR, I started writing a Getting started guide. I don't know where to publish this or whether it makes sense to publish it.

Next steps:

Publish one getting started guide (one the website??)

JoshVanL

A few comments from me, but otherwise looks good.

/assign @maelvls

content/en/docs/configuration/acme/http01/_index.md

JoshVanL · 2021-08-10T10:31:34Z

content/en/docs/configuration/acme/http01/_index.md

+solving the HTTP-01 challenge. These labels must match one of the Gateway
+resources on your cluster. The matched Gateway have a listener on port 80.


What happens if no Gateways match?

I added the following note:

Note that when the labels do not match any Gateway on your cluster, cert-manager will create the temporary HTTPRoute challenge and nothing will happen.

content/en/docs/usage/gateway.md

content/en/docs/configuration/acme/http01/_index.md

Signed-off-by: Maël Valais <mael@vls.dev> Co-authored-by: JoshVanL <vleeuwenjoshua@gmail.com>

maelvls · 2021-08-11T08:31:59Z

Done!
/unassign
/assign @JoshVanL

wallrj

Looks great @maelvls

Thanks.

/lgtm
/approve

wallrj · 2021-08-11T10:21:48Z

content/en/docs/configuration/acme/http01/_index.md

+  ```sh
+  helm upgrade --install cert-manager jetstack/cert-manager --namespace cert-manager \
+    --set "extraArgs={--feature-gates=ExperimentalGatewayAPISupport=true}"
+  ```


Random thought: If you'd previously enabled the experimental CertificateRequestSupport would this command disable that. I do not propose changing this command, but it is worth thinking about how easy it is to change extraArgs values during an upgrade.

Good point, I wish we could instead re-use the same flag multiple times:

helm upgrade --install cert-manager jetstack/cert-manager --namespace cert-manager \ --set extraArgs="--feature-gates=ExperimentalGatewayAPISupport=true" \ --set extraArgs="--feature-gates=ExperimentalCertificateRequestSupport=true"

But the only way to set arrays from the command line is to use the syntax extraArgs={...,...} 😞

jetstack-bot · 2021-08-11T10:23:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [maelvls]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

maelvls changed the base branch from master to release-next June 22, 2021 16:54

JoshVanL requested changes Jul 30, 2021

View reviewed changes

content/en/docs/configuration/acme/http01/_index.md Outdated Show resolved Hide resolved

content/en/docs/configuration/acme/http01/_index.md Outdated Show resolved Hide resolved

maelvls force-pushed the gateway-api-documentation branch from 6518364 to ed223e5 Compare August 4, 2021 12:30

jetstack-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 4, 2021

maelvls force-pushed the gateway-api-documentation branch from ed223e5 to 4e5ce0f Compare August 4, 2021 17:29

jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2021

maelvls force-pushed the gateway-api-documentation branch from 4e5ce0f to ac8e0e3 Compare August 4, 2021 17:31

wallrj reviewed Aug 5, 2021

View reviewed changes

.gitattributes Show resolved Hide resolved

content/en/docs/configuration/acme/http01/_index.md Outdated Show resolved Hide resolved

content/en/docs/configuration/acme/http01/_index.md Outdated Show resolved Hide resolved

maelvls mentioned this pull request Aug 5, 2021

Document the certificate shim support for Gateways #640

Merged

maelvls added 2 commits August 5, 2021 14:50

.spelling: let's let Git automatically union-merge on conflict

8bdb852

Signed-off-by: Maël Valais <mael@vls.dev>

gateway-solver: document the use of the HTTPRoute solver

caf4df6

Signed-off-by: Maël Valais <mael@vls.dev>

jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2021

maelvls force-pushed the gateway-api-documentation branch from ac8e0e3 to f29a49d Compare August 5, 2021 13:33

jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2021

maelvls marked this pull request as ready for review August 5, 2021 13:34

jetstack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2021

maelvls force-pushed the gateway-api-documentation branch from f29a49d to 1d42ae2 Compare August 5, 2021 13:44

review: stable -> alpha, add --feature-gates=GatewayAPI=true

a007acf

Signed-off-by: Maël Valais <mael@vls.dev>

maelvls force-pushed the gateway-api-documentation branch from 1d42ae2 to a007acf Compare August 5, 2021 15:31

gateway-solver: detail what the HTTPRoute may look like

f373024

Signed-off-by: Maël Valais <mael@vls.dev>

maelvls force-pushed the gateway-api-documentation branch from fd00880 to f373024 Compare August 5, 2021 15:51

gateway-shim+solver: GatewayAPI -> ExperimentalGatewayAPISupport

299c6aa

This is the feature gate name that was picked in cert-manager/cert-manager#4310. Signed-off-by: Maël Valais <mael@vls.dev>

JoshVanL requested changes Aug 10, 2021

View reviewed changes

jetstack-bot assigned maelvls Aug 10, 2021

maelvls force-pushed the gateway-api-documentation branch 2 times, most recently from c8a6d0b to 8f5db75 Compare August 11, 2021 08:27

review: explain what happens when no Gateway is match by labels

eaefa68

Signed-off-by: Maël Valais <mael@vls.dev> Co-authored-by: JoshVanL <vleeuwenjoshua@gmail.com>

maelvls force-pushed the gateway-api-documentation branch from 8f5db75 to eaefa68 Compare August 11, 2021 08:30

jetstack-bot assigned JoshVanL and unassigned maelvls Aug 11, 2021

wallrj approved these changes Aug 11, 2021

View reviewed changes

jetstack-bot assigned wallrj Aug 11, 2021

jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2021

JoshVanL added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager label Aug 11, 2021

jetstack-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 11, 2021

jetstack-bot merged commit 35df077 into cert-manager:release-next Aug 11, 2021

maelvls mentioned this pull request Aug 11, 2021

v1.5 Public Roadmap cert-manager/cert-manager#4120

Closed

13 tasks

This was referenced Aug 11, 2021

Merge release-next into master for the 1.5 release #675

Merged

Update build scripts for 1.5 #680

Merged

jetstack-bot mentioned this pull request Oct 27, 2021

Update the release-1.5 branch #732

Merged

		solving the HTTP-01 challenge. These labels must match one of the Gateway
		resources on your cluster. The matched Gateway have a listener on port 80.

Conversation

maelvls commented Jun 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jetstack-bot commented Jun 22, 2021

Uh oh!

JoshVanL left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Aug 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maelvls commented Aug 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoshVanL left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoshVanL Aug 10, 2021

Choose a reason for hiding this comment

Uh oh!

maelvls Aug 11, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maelvls commented Aug 11, 2021

Uh oh!

wallrj left a comment

Choose a reason for hiding this comment

Uh oh!

wallrj Aug 11, 2021

Choose a reason for hiding this comment

Uh oh!

maelvls Aug 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jetstack-bot commented Aug 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

maelvls commented Jun 22, 2021 •

edited

Loading

netlify bot commented Aug 4, 2021 •

edited

Loading

maelvls commented Aug 9, 2021 •

edited

Loading

maelvls Aug 11, 2021 •

edited

Loading