Skip to content

Remove the spelling exceptions, they are not needed anymore since #588#590

Closed
maelvls wants to merge 2 commits intocert-manager:release-nextfrom
maelvls:rm-unused-spelling
Closed

Remove the spelling exceptions, they are not needed anymore since #588#590
maelvls wants to merge 2 commits intocert-manager:release-nextfrom
maelvls:rm-unused-spelling

Conversation

@maelvls
Copy link
Member

@maelvls maelvls commented Jun 8, 2021

The reason why I had to remove .spelling exceptions is that ./scripts/verify clones from the branch release-next into the /docs-next folder, but the .spelling additions that were made to release-next branch aren't know by alex. That means any word added .spelling and merged to release-next will break ./script/verify for any other branch.

In #588, I removed the need for the two .spelling additions. In this PR, I remove the words entirely since they are not needed anymore.

maelvls added 2 commits June 8, 2021 17:59
Signed-off-by: Maël Valais <mael@vls.dev>
The reason why I had to remove .spelling exceptions is that
./scripts/verify clones from the branch "release-next" into
the /docs-next folder, but the .spelling that were made to
release-next aren't know by alex. That means any word added
.spelling in release-next will break ./script/verify for any
other branch.

Signed-off-by: Maël Valais <mael@vls.dev>
@jetstack-bot
Copy link
Contributor

@maelvls: This PR is not for the master branch but does not have the cherry-pick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Jun 8, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 8, 2021
@jetstack-bot
Copy link
Contributor

@maelvls: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cert-manager-website-verify a0e9239 link /test pull-cert-manager-website-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@maelvls
Copy link
Member Author

maelvls commented Jun 9, 2021

Not needed anymore after #591

/close

@jetstack-bot
Copy link
Contributor

@maelvls: Closed this PR.

Details

In response to this:

Not needed anymore after #591

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maelvls maelvls deleted the rm-unused-spelling branch June 9, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants