Skip to content

Reinstate pull-cert-manager-chart presubmit for previous branches#687

Merged
jetstack-bot merged 2 commits intocert-manager:masterfrom
irbekrm:reinstate_pull_chart
May 13, 2022
Merged

Reinstate pull-cert-manager-chart presubmit for previous branches#687
jetstack-bot merged 2 commits intocert-manager:masterfrom
irbekrm:reinstate_pull_chart

Conversation

@irbekrm
Copy link
Contributor

@irbekrm irbekrm commented May 13, 2022

In #660 we moved all 'previous' presubmit definitions to https://github.com/jetstack/testing/blob/master/config/jobs/cert-manager/cert-manager/release-previous/cert-manager-release-previous-presubmits.yaml (whereas previouosly some of those presubmits were available for the previous branches because they were included in the 'default' presubmits file i.e here
pull-cert-manager-chart got lost in the change and as it is required is currently blocking backport PRs.

Signed-off-by: irbekrm <irbekrm@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/cert-manager Indicates a PR related to cert-manager approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 13, 2022
Signed-off-by: irbekrm <irbekrm@gmail.com>
@irbekrm irbekrm force-pushed the reinstate_pull_chart branch from 06feed9 to 9578062 Compare May 13, 2022 11:20
@irbekrm irbekrm changed the title Reinstate pull chart Reinstate pull-cert-manager-chart presubmit for previous branches May 13, 2022
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2022
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 412bb2e into cert-manager:master May 13, 2022
@jetstack-bot
Copy link
Contributor

@irbekrm: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key cert-manager-presubmits.yaml using file config/jobs/cert-manager/cert-manager/cert-manager-presubmits.yaml
  • key cert-manager-release-previous-presubmits.yaml using file config/jobs/cert-manager/cert-manager/release-previous/cert-manager-release-previous-presubmits.yaml
Details

In response to this:

In #660 we moved all 'previous' presubmit definitions to https://github.com/jetstack/testing/blob/master/config/jobs/cert-manager/cert-manager/release-previous/cert-manager-release-previous-presubmits.yaml (whereas previouosly some of those presubmits were available for the previous branches because they were included in the 'default' presubmits file i.e here
pull-cert-manager-chart got lost in the change and as it is required is currently blocking backport PRs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@irbekrm irbekrm deleted the reinstate_pull_chart branch May 13, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cert-manager Indicates a PR related to cert-manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants