Conversation
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
SgtCoDFish
left a comment
There was a problem hiding this comment.
(on my phone on a train, sorry for bad formatting and short comments!)
| branches: | ||
| - master | ||
| - release-1.8 | ||
| - release-1.9 |
There was a problem hiding this comment.
Suggestion: as I mentioned in the 1.8.0 release thread on slack, I didn't create release-1.9. We can just test master here
There was a problem hiding this comment.
I agree, let’s get rid of release-1.9 for now until we do an alpha release. I explained and fixed this in eb52868.
config/jobs/cert-manager/cert-manager/cert-manager-presubmits.yaml
Outdated
Show resolved
Hide resolved
config/jobs/cert-manager/cert-manager/release-next/cert-manager-release-next-periodics.yaml
Outdated
Show resolved
Hide resolved
config/jobs/cert-manager/cert-manager/cert-manager-periodics.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Maël Valais <mael@vls.dev> Co-Authored-By: Ashley Davis <ashley.davis@jetstack.io>
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev> Co-Authored-By: Ashley Davis <ashley.davis@jetstack.io>
Signed-off-by: Maël Valais <mael@vls.dev> Co-Authored-By: Ashley Davis <ashley.davis@jetstack.io>
SgtCoDFish
left a comment
There was a problem hiding this comment.
We're also missing updates to the old presubmits and periodics, e.g.: https://github.com/jetstack/testing/blob/master/config/jobs/cert-manager/cert-manager/release-previous/cert-manager-release-previous-periodics.yaml
We need to test both release-1.7 and release-1.8 for release-previous
config/jobs/cert-manager/cert-manager/release-next/cert-manager-release-next-periodics.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
SgtCoDFish
left a comment
There was a problem hiding this comment.
/lgtm
/approve
I think any other changes we need can easily come in a separate PR, this looks good! Thanks
| # We don't need periodically testing the release-next breanch (e.g., the | ||
| # "release-1.9" branch) until we release the first alpha (e.g., | ||
| # "1.9.0-alpha.0"). Since we can't "deactivate" the release-next periodics | ||
| # jobs until we have an alpha (there is no "skip" field on the ProwJob | ||
| # object), we just remove all of the jobs from this file. That's why the | ||
| # below array is empty. See Step 13.3 in | ||
| # https://cert-manager.io/docs/contributing/release-process/ |
There was a problem hiding this comment.
nit(non-blocking): grammar
| # We don't need periodically testing the release-next breanch (e.g., the | |
| # "release-1.9" branch) until we release the first alpha (e.g., | |
| # "1.9.0-alpha.0"). Since we can't "deactivate" the release-next periodics | |
| # jobs until we have an alpha (there is no "skip" field on the ProwJob | |
| # object), we just remove all of the jobs from this file. That's why the | |
| # below array is empty. See Step 13.3 in | |
| # https://cert-manager.io/docs/contributing/release-process/ | |
| # We don't need to periodically test the release-next breanch (e.g., the | |
| # "release-1.9" branch) until we release the first alpha (e.g., | |
| # "1.9.0-alpha.0"). Since we can't "deactivate" the release-next periodics | |
| # jobs until we have an alpha (there is no "skip" field on the ProwJob | |
| # object), we just remove all of the jobs from this file. That's why the | |
| # below array is empty. See Step 13.3 in | |
| # https://cert-manager.io/docs/contributing/release-process/ |
There was a problem hiding this comment.
Oops, good catch. Thanks. I'll fix that the next time I get to edit this file if that's OK
There was a problem hiding this comment.
It's all good, I'm fixing it in the PR I'm working on for release-previous 👍
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelvls, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@maelvls: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Based on:
I also did the following: