Skip to content

Update jobs to 1.9#659

Merged
jetstack-bot merged 13 commits intocert-manager:masterfrom
maelvls:update-jobs-to-1.9
Apr 11, 2022
Merged

Update jobs to 1.9#659
jetstack-bot merged 13 commits intocert-manager:masterfrom
maelvls:update-jobs-to-1.9

Conversation

@maelvls
Copy link
Copy Markdown
Member

@maelvls maelvls commented Apr 6, 2022

Based on:

I also did the following:

  • I moved all the cert-mananger-release-next-periodics and cert-mananger-periodics to make since I think we don't need to keep Bazel running on those;
  • I did not change anything (appart from changing the branch release-1.8 to release-1.9) in cert-manager-presubmits since that may break when releasing older versions of cert-manager.

maelvls added 4 commits April 6, 2022 11:56
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/cert-manager Indicates a PR related to cert-manager approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 6, 2022
Copy link
Copy Markdown
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(on my phone on a train, sorry for bad formatting and short comments!)

branches:
- master
- release-1.8
- release-1.9
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: as I mentioned in the 1.8.0 release thread on slack, I didn't create release-1.9. We can just test master here

Copy link
Copy Markdown
Member Author

@maelvls maelvls Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, let’s get rid of release-1.9 for now until we do an alpha release. I explained and fixed this in eb52868.

maelvls and others added 4 commits April 7, 2022 13:04
Signed-off-by: Maël Valais <mael@vls.dev>
Co-Authored-By: Ashley Davis <ashley.davis@jetstack.io>
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
Co-Authored-By: Ashley Davis <ashley.davis@jetstack.io>
Signed-off-by: Maël Valais <mael@vls.dev>
Co-Authored-By: Ashley Davis <ashley.davis@jetstack.io>
Copy link
Copy Markdown
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're also missing updates to the old presubmits and periodics, e.g.: https://github.com/jetstack/testing/blob/master/config/jobs/cert-manager/cert-manager/release-previous/cert-manager-release-previous-periodics.yaml

We need to test both release-1.7 and release-1.8 for release-previous

maelvls added 5 commits April 11, 2022 11:39
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
Copy link
Copy Markdown
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

I think any other changes we need can easily come in a separate PR, this looks good! Thanks

Comment on lines +1 to +7
# We don't need periodically testing the release-next breanch (e.g., the
# "release-1.9" branch) until we release the first alpha (e.g.,
# "1.9.0-alpha.0"). Since we can't "deactivate" the release-next periodics
# jobs until we have an alpha (there is no "skip" field on the ProwJob
# object), we just remove all of the jobs from this file. That's why the
# below array is empty. See Step 13.3 in
# https://cert-manager.io/docs/contributing/release-process/
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit(non-blocking): grammar

Suggested change
# We don't need periodically testing the release-next breanch (e.g., the
# "release-1.9" branch) until we release the first alpha (e.g.,
# "1.9.0-alpha.0"). Since we can't "deactivate" the release-next periodics
# jobs until we have an alpha (there is no "skip" field on the ProwJob
# object), we just remove all of the jobs from this file. That's why the
# below array is empty. See Step 13.3 in
# https://cert-manager.io/docs/contributing/release-process/
# We don't need to periodically test the release-next breanch (e.g., the
# "release-1.9" branch) until we release the first alpha (e.g.,
# "1.9.0-alpha.0"). Since we can't "deactivate" the release-next periodics
# jobs until we have an alpha (there is no "skip" field on the ProwJob
# object), we just remove all of the jobs from this file. That's why the
# below array is empty. See Step 13.3 in
# https://cert-manager.io/docs/contributing/release-process/

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch. Thanks. I'll fix that the next time I get to edit this file if that's OK

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all good, I'm fixing it in the PR I'm working on for release-previous 👍

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2022
@jetstack-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 3297c13 into cert-manager:master Apr 11, 2022
@jetstack-bot
Copy link
Copy Markdown
Contributor

@maelvls: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key cert-manager-periodics.yaml using file config/jobs/cert-manager/cert-manager/cert-manager-periodics.yaml
  • key cert-manager-presubmits.yaml using file config/jobs/cert-manager/cert-manager/cert-manager-presubmits.yaml
  • key cert-manager-release-next-periodics.yaml using file config/jobs/cert-manager/cert-manager/release-next/cert-manager-release-next-periodics.yaml
Details

In response to this:

Based on:

I also did the following:

  • I moved all the cert-mananger-release-next-periodics and cert-mananger-periodics to make since I think we don't need to keep Bazel running on those;
  • I did not change anything (appart from changing the branch release-1.8 to release-1.9) in cert-manager-presubmits since that may break when releasing older versions of cert-manager.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maelvls maelvls deleted the update-jobs-to-1.9 branch April 11, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cert-manager Indicates a PR related to cert-manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants