Skip to content

use go 1.17 for website job#618

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
jahrlin:master
Jan 21, 2022
Merged

use go 1.17 for website job#618
jetstack-bot merged 1 commit intocert-manager:masterfrom
jahrlin:master

Conversation

@jahrlin
Copy link
Contributor

@jahrlin jahrlin commented Jan 21, 2022

Needed for: cert-manager/website#800

We need to use the same go version as cert-manager, which is 1.17

Signed-off-by: Joakim Ahrlin joakim.ahrlin@gmail.com

@jahrlin
use go 1.17 for website job
0653ca0 
Signed-off-by: Joakim Ahrlin <joakim.ahrlin@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/cert-manager Indicates a PR related to cert-manager approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2022
@jakexks
Copy link
Member

jakexks commented Jan 21, 2022

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2022
jakexks
jakexks approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@jakexks jakexks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@jetstack-bot jetstack-bot merged commit 22040cd into cert-manager:master Jan 21, 2022
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Jan 21, 2022

@jahrlin: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key cert-manager-website-presubmits.yaml using file config/jobs/cert-manager/website/cert-manager-website-presubmits.yaml
Details

In response to this:

Needed for: cert-manager/website#800

We need to use the same go version as cert-manager, which is 1.17

Signed-off-by: Joakim Ahrlin joakim.ahrlin@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot
Copy link
Contributor

jetstack-bot commented Jan 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jahrlin, jakexks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakexks jakexks jakexks approved these changes

Assignees

@jakexks jakexks

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cert-manager Indicates a PR related to cert-manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jahrlin @jakexks @jetstack-bot