Skip to content

Update configuration for the next cert-manager release 1.7 #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jetstack-bot merged 7 commits into from
Oct 29, 2021
Merged

Update configuration for the next cert-manager release 1.7 #605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
869d8e4
Run the pre-submit jobs against master and release-1.7
wallrj Oct 28, 2021
54906a1
Run release-next periodic jobs against release-1.7
wallrj Oct 28, 2021
839c61e
Run release-previous pre-submits and periodics against release-1.6
wallrj Oct 28, 2021
e8c0410
Configure milestone_applier for cert-manager current 1.6 and next 1.7…
wallrj Oct 28, 2021
bfbd4da
Sync release-previous job manifests with those in current and release…
wallrj Oct 28, 2021
6e3414c
Fix inaccurate comment
wallrj Oct 29, 2021
2b9b992
Sync the master periodics jobs with release-next jobs
wallrj Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions config/jobs/cert-manager/cert-manager-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ presubmits:
decorate: true
branches:
- master
- release-1.6
- release-1.7
annotations:
testgrid-create-test-group: 'true'
testgrid-dashboards: jetstack-cert-manager-presubmits-blocking
Expand Down Expand Up @@ -46,7 +46,7 @@ presubmits:
decorate: true
branches:
- master
- release-1.6
- release-1.7
annotations:
testgrid-create-test-group: 'false'
description: Runs 'bazel test --jobs=1 //...'
Expand Down Expand Up @@ -81,7 +81,7 @@ presubmits:
decorate: true
branches:
- master
- release-1.6
- release-1.7
annotations:
testgrid-create-test-group: 'false'
description: Runs 'bazel test --jobs=1 //...'
Expand Down Expand Up @@ -117,7 +117,7 @@ presubmits:
decorate: true
branches:
- master
- release-1.6
- release-1.7
annotations:
testgrid-create-test-group: 'true'
testgrid-dashboards: jetstack-cert-manager-presubmits-blocking
Expand Down Expand Up @@ -155,7 +155,7 @@ presubmits:
decorate: true
branches:
- master
- release-1.6
- release-1.7
annotations:
testgrid-create-test-group: 'true'
testgrid-dashboards: jetstack-cert-manager-presubmits-blocking
Expand Down Expand Up @@ -192,7 +192,7 @@ presubmits:
decorate: true
branches:
- master
- release-1.6
- release-1.7
annotations:
testgrid-create-test-group: 'true'
testgrid-dashboards: jetstack-cert-manager-presubmits-blocking
Expand Down Expand Up @@ -227,7 +227,7 @@ presubmits:
decorate: true
branches:
- master
- release-1.6
- release-1.7
annotations:
testgrid-create-test-group: 'true'
testgrid-dashboards: jetstack-cert-manager-presubmits-blocking
Expand Down Expand Up @@ -287,7 +287,7 @@ presubmits:
decorate: true
branches:
- master
- release-1.6
- release-1.7
annotations:
testgrid-create-test-group: 'true'
testgrid-dashboards: jetstack-cert-manager-presubmits-blocking
Expand Down Expand Up @@ -347,7 +347,7 @@ presubmits:
decorate: true
branches:
- master
- release-1.6
- release-1.7
annotations:
testgrid-create-test-group: 'true'
testgrid-dashboards: jetstack-cert-manager-presubmits-blocking
Expand Down Expand Up @@ -407,7 +407,7 @@ presubmits:
decorate: true
branches:
- master
- release-1.6
- release-1.7
annotations:
testgrid-create-test-group: 'true'
testgrid-dashboards: jetstack-cert-manager-presubmits-blocking
Expand Down Expand Up @@ -467,7 +467,7 @@ presubmits:
decorate: true
branches:
- master
- release-1.6
- release-1.7
annotations:
testgrid-create-test-group: 'true'
testgrid-dashboards: jetstack-cert-manager-presubmits-blocking
Expand Down Expand Up @@ -527,7 +527,7 @@ presubmits:
decorate: true
branches:
- master
- release-1.6
- release-1.7
annotations:
testgrid-create-test-group: 'true'
testgrid-dashboards: jetstack-cert-manager-presubmits-blocking
Expand Down Expand Up @@ -580,15 +580,15 @@ presubmits:

- name: pull-cert-manager-e2e-v1-22
context: pull-cert-manager-e2e-v1-22
# This is the default e2e test ran for all PRs to master.
# This is the default e2e test for all PRs.
always_run: true
optional: false
max_concurrency: 4
agent: kubernetes
decorate: true
branches:
- master
- release-1.6
- release-1.7
annotations:
testgrid-create-test-group: 'true'
testgrid-dashboards: jetstack-cert-manager-presubmits-blocking
Expand Down Expand Up @@ -653,7 +653,7 @@ presubmits:
decorate: true
branches:
- master
- release-1.6
- release-1.7
annotations:
description: Runs cert-manager upgrade from latest published release
labels:
Expand Down
32 changes: 16 additions & 16 deletions config/jobs/cert-manager/release-next/cert-manager-release-next-periodics.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ periodics:
extra_refs:
- org: jetstack
repo: cert-manager
base_ref: release-1.6
base_ref: release-1.7
Copy link
Member

@SgtCoDFish SgtCoDFish Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion/question: I understand why this has been changed to release-1.7, and I'd be fine with it staying this way... but for at least the next few weeks, am I correct that these tests aren't going to do anything useful in practice, because we won't be updating the release-1.7 branch?

We could just comment out this whole config file basically until we do our first alpha for 1.7 and we'd lose nothing, I think. Periodics run against master do the "release-next" job until we create our first alpha.

(We've talked about wanting to do alphas more often, but we're not there yet and I'm thinking we could save some resources on our test cluster here)

Am I missing something? Could we, for now, not do any of these tests, or else maybe only run them every 2 days or every week rather than every 2 hours?

(I fully accept that this is a tangent to your PR here, and if you'd rather not have this discussion in this PR, then fair enough!)

Copy link
Member Author

@wallrj wallrj Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. The release-1.7 branch will only ever be identical to, or behind master, so it's pointless to run these tests right now....but it's what we've always done so I propose not changing that in this PR.
We could create another PR to disable them

Copy link
Member

@SgtCoDFish SgtCoDFish Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it's what we've always done so I propose not changing that in this PR.

Totally reasonable to leave it for a separate PR, yeah. I might raise that PR after this merges 👍

Copy link
Member

@munnerz munnerz Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think in the past we have not created the release branch until we actually want to cut a release (i.e. just before the first alpha)

labels:
preset-service-account: "true"
preset-bazel-remote-cache-enabled: "true"
Expand All @@ -32,8 +32,8 @@ periodics:
memory: 4Gi
dnsConfig:
options:
- name: ndots
value: "1"
- name: ndots
value: "1"

# Re-add bazel-experimental periodics once Bazel v5.0.0 is released and we have
# a bazelbuild image with that https://github.com/bazelbuild/bazel/releases
Expand All @@ -45,7 +45,7 @@ periodics:
extra_refs:
- org: jetstack
repo: cert-manager
base_ref: release-1.6
base_ref: release-1.7
labels:
preset-service-account: "true"
preset-dind-enabled: "true"
Expand Down Expand Up @@ -93,8 +93,8 @@ periodics:
type: Directory
dnsConfig:
options:
- name: ndots
value: "1"
- name: ndots
value: "1"

- name: ci-cert-manager-next-e2e-v1-17
interval: 2h
Expand All @@ -103,7 +103,7 @@ periodics:
extra_refs:
- org: jetstack
repo: cert-manager
base_ref: release-1.6
base_ref: release-1.7
annotations:
testgrid-create-test-group: 'true'
testgrid-dashboards: jetstack-cert-manager-next
Expand Down Expand Up @@ -161,7 +161,7 @@ periodics:
extra_refs:
- org: jetstack
repo: cert-manager
base_ref: release-1.6
base_ref: release-1.7
annotations:
testgrid-create-test-group: 'true'
testgrid-dashboards: jetstack-cert-manager-next
Expand Down Expand Up @@ -219,7 +219,7 @@ periodics:
extra_refs:
- org: jetstack
repo: cert-manager
base_ref: release-1.6
base_ref: release-1.7
annotations:
testgrid-create-test-group: 'true'
testgrid-dashboards: jetstack-cert-manager-next
Expand Down Expand Up @@ -277,7 +277,7 @@ periodics:
extra_refs:
- org: jetstack
repo: cert-manager
base_ref: release-1.6
base_ref: release-1.7
annotations:
testgrid-create-test-group: 'true'
testgrid-dashboards: jetstack-cert-manager-next
Expand Down Expand Up @@ -335,7 +335,7 @@ periodics:
extra_refs:
- org: jetstack
repo: cert-manager
base_ref: release-1.6
base_ref: release-1.7
annotations:
testgrid-create-test-group: 'true'
testgrid-dashboards: jetstack-cert-manager-next
Expand Down Expand Up @@ -393,7 +393,7 @@ periodics:
extra_refs:
- org: jetstack
repo: cert-manager
base_ref: release-1.6
base_ref: release-1.7
annotations:
testgrid-create-test-group: 'true'
testgrid-dashboards: jetstack-cert-manager-next
Expand Down Expand Up @@ -444,21 +444,21 @@ periodics:
- name: ndots
value: "1"

# This test runs Venafi (VaaS and TPP) tests once every 12hrs. This is the only CI test
# job that runs those periodically against release-1.6.
# This test runs Venafi (VaaS and TPP) tests once every 24hrs.
# This is the only CI test job that runs those.
- name: ci-cert-manager-next-venafi
interval: 24h
agent: kubernetes
decorate: true
extra_refs:
- org: jetstack
repo: cert-manager
base_ref: release-1.6
base_ref: release-1.7
annotations:
testgrid-create-test-group: 'true'
testgrid-dashboards: jetstack-cert-manager-master
testgrid-alert-email: cert-manager-dev-alerts@googlegroups.com
description: Runs Venafi Cloud e2e tests against Kubernetes v1.22 cluster
description: Runs Venafi (VaaS and TPP) e2e tests against Kubernetes v1.22 cluster
labels:
preset-service-account: "true"
preset-dind-enabled: "true"
Expand Down
Loading