LHCb Open Data Release Vol2 #3457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did we run out of recIDs? |
Just ran into ones that were in the meantime taken by the CMS heavy ion release. Please use the new record ID interval starting from 28000. |
tiborsimko
force-pushed
the
LHCbOpenDataReleaseVOL2
branch
from
4b8a6e0 to
dbd0aca
Compare
tiborsimko
reviewed
Nov 28, 2023
There was a problem hiding this comment.
@MindaugasSarpis Thanks! As spoken IRL, this PR touches already-released data streams, so I'll leave it out from the PR.
One minor change is related to descriptions:
- old way (already released): "proton-proton (pp) collision data collected by the LHCb experiment in the year 2012 of Run1 of the LHC."
- new way (this PR): "Data from proton-proton (pp) collisions collected by the LHCb experiment in the year 2012 of Run1 of the LHC."
Which one do you prefer?
tiborsimko
force-pushed
the
LHCbOpenDataReleaseVOL2
branch
from
dbd0aca to
bab5652
Compare
What I did:
sed -i -e 's/\s*\\n\s*/ /g' cernopendata/modules/fixtures/data/records/LHCb_201*json
sed -i -e 's/"release": " /"release": "/g' cernopendata/modules/fixtures/data/records/LHCb_201*json
sed -i -e 's/"description": "proton-proton (pp) collision data collected/"description": "Data from proton-proton (pp) collisions collected/g' cernopendata/modules/fixtures/data/records/LHCb_201*json
for file in $(find cernopendata/modules/fixtures/data/docs/lhcb-stripping/ -name "*.json"); do ./scripts/clean_json_file.py $file; done
for file in $(find cernopendata/modules/fixtures/data/records/ -name "LHCb*.json"); do ./scripts/clean_json_file.py $file; done |
tiborsimko
force-pushed
the
LHCbOpenDataReleaseVOL2
branch
from
bab5652 to
937c8a3
Compare
Amends already-published stripping line documentation to include information for all stripping version / stream / line combinations in view of releasing six more data streams from Run1. Co-authored-by: Tibor Šimko <[email protected]>
Adds six new LHCb open data streams from Run1 for the forthcoming release. Amends abstract descriptions of previously released Run1 data streams for consistency. Co-authored-by: Tibor Šimko <[email protected]>
tiborsimko
force-pushed
the
LHCbOpenDataReleaseVOL2
branch
from
937c8a3 to
91d5d5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 6 more stripping streams across all stripping versions. Added documentation pages for all stripping version / stream / line combinations.