Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Update prettifyJSON script #833

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Update prettifyJSON script #833

merged 6 commits into from
Nov 6, 2023

Conversation

sdadn
Copy link
Contributor

@sdadn sdadn commented Nov 6, 2023

Summary

This PR updates the prettifyJSON script by:

  • Adding the now utilized workspaces field.
  • Reordering the props for better logical grouping. the props are now ordered as infro props, package settings props, config props, dependencies & scripts.
  • Adding all additional keys alphabetically above dependencies instead of in the otherKeys field.
  • Adding jest tests.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

This was also tested by successfully running it on the terra-framework-repo:

CleanShot 2023-11-06 at 09 38 19

CleanShot 2023-11-06 at 14 34 28

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details


Thank you for contributing to Terra.
@cerner/terra

@sdadn sdadn self-assigned this Nov 6, 2023
@sdadn sdadn requested a review from a team as a code owner November 6, 2023 15:39
@github-actions github-actions bot temporarily deployed to preview-pr-833 November 6, 2023 19:25 Destroyed
@sdadn
Copy link
Contributor Author

sdadn commented Nov 6, 2023

All the Jest tests pass locally; the one failure should not be caused by this change:

CleanShot 2023-11-06 at 14 32 26

@sdadn sdadn changed the title Update prettifyfJSON script Update prettifyJSON script Nov 6, 2023
@sdadn sdadn merged commit 1922190 into main Nov 6, 2023
4 of 5 checks passed
@sdadn sdadn deleted the update-prettify-JSON-script branch November 6, 2023 21:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants