This repository has been archived by the owner on May 22, 2024. It is now read-only.
[package-json-lint] Add a flag to mark a project as application, module, or devModule. #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranav300
requested review from
mjhenkes,
ryanthemanuel,
supreethmr,
lokesh-0813,
saket2403 and
ShettyAkarsh
benbcai
reviewed
Aug 24, 2021
benbcai
reviewed
Aug 24, 2021
...es/package-json-lint/tests/jest/rules/require-no-terra-base-peer-dependency-versions.test.js
Outdated
Show resolved
Hide resolved
benbcai
approved these changes
Aug 24, 2021
ShettyAkarsh
approved these changes
Aug 25, 2021
mjhenkes
approved these changes
Aug 30, 2021
ryanthemanuel
approved these changes
Aug 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a variable
projectTypeto flag a project as application, module, or devModule.The fallback value for
projectTypeismodule. Currently seems a most common scenario.Closes #696
@cerner/terra