This repository has been archived by the owner on May 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 37
[webpack-config-terra] Upgrade to sass (dart-sass) #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranav300
requested review from
supreethmr,
lokesh-0813,
saket2403 and
ShettyAkarsh
July 20, 2021 13:23
pranav300
requested review from
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
July 20, 2021 13:23
mjhenkes
reviewed
Jul 20, 2021
packages/terra-toolkit-docs/src/terra-dev-site/tool/webpackConfigTerra/UpgradeGuide.y.tool.mdx
Outdated
Show resolved
Hide resolved
Can you reverse the order of the upgrade guides? version 2 above version 1 |
mjhenkes
reviewed
Jul 21, 2021
...rc/terra-dev-site/tool/webpackConfigTerra/upgrade-guide.6/version-2-upgrade-guide.2.tool.mdx
Outdated
Show resolved
Hide resolved
mjhenkes
reviewed
Jul 21, 2021
...rc/terra-dev-site/tool/webpackConfigTerra/upgrade-guide.6/version-2-upgrade-guide.2.tool.mdx
Outdated
Show resolved
Hide resolved
mjhenkes
reviewed
Jul 21, 2021
Co-authored-by: Matt Henkes <[email protected]>
…figTerra/upgrade-guide.6/version-2-upgrade-guide.2.tool.mdx Co-authored-by: Matt Henkes <[email protected]>
…figTerra/upgrade-guide.6/version-2-upgrade-guide.2.tool.mdx Co-authored-by: Matt Henkes <[email protected]>
mjhenkes
approved these changes
Jul 26, 2021
benbcai
approved these changes
Jul 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates webpack-config-terra from node-sass to sass (dart-sass).
Closes #676
Additional Details
@cerner/terra