Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Update waitForSeleniumHubReady to accommodate Windows users #661

Merged
merged 6 commits into from
May 26, 2021

Conversation

kaylabarnett
Copy link
Contributor

@kaylabarnett kaylabarnett commented May 25, 2021

Update poll command within waitForSeleniumHubReady to accommodate Windows users running WDIO tests

Summary

Made an update to the poll command within waitForSeleniumHubReady to use single quotes. This change was made as using double quotes is causing parsing issues when the method is executed on Windows machines. This was found during development via one of our EPAM teams.

Additional Details

Closes #663

@cerner/terra

Update poll command within waitForSeleniumHubReady to accommodate Windows users running WDIO tests
@mjhenkes
Copy link
Contributor

@kaylabarnett thank you for the contribution!

Could you add yourself as a contributor here: https://github.com/kaylabarnett/terra-toolkit/blob/main/CONTRIBUTORS.md

Copy link
Contributor

@yuderekyu yuderekyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaylabarnett thank you for the contribution! can we get someone with a windows machine to verify that this works?

@benbcai
Copy link
Contributor

benbcai commented May 26, 2021

@kaylabarnett thank you for the contribution! can we get someone with a windows machine to verify that this works?

It's always good to have additional verification. Another Windows consumer ran into this issue recently but I had not heard back from them whether or not it resolved their issue. I just reached out and they confirmed that this change did resolve their issue so we can also use this as verification.

Screen Shot 2021-05-26 at 10 15 47 AM

Note: The Chrome not reachable error is a separate issue not related to this change.

@kaylabarnett
Copy link
Contributor Author

@kaylabarnett thank you for the contribution! can we get someone with a windows machine to verify that this works?

It's always good to have additional verification. Another Windows consumer ran into this issue recently but I had not heard back from them whether or not it resolved their issue. I just reached out and they confirmed that this change did resolve their issue so we can also use this as verification.

Screen Shot 2021-05-26 at 10 15 47 AM

Note: The Chrome not reachable error is a separate issue not related to this change.

If we need additional verification I can reach out to my EPAM team to have them verify

@benbcai
Copy link
Contributor

benbcai commented May 26, 2021

@kaylabarnett I think we're good as far as verification goes.

@benbcai benbcai closed this May 26, 2021
@benbcai benbcai reopened this May 26, 2021
@mjhenkes mjhenkes merged commit f514f8e into cerner:main May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[terra-functional-testing] Invalid docker command for Windows
4 participants