-
Notifications
You must be signed in to change notification settings - Fork 37
Update waitForSeleniumHubReady to accommodate Windows users #661
Conversation
Update poll command within waitForSeleniumHubReady to accommodate Windows users running WDIO tests
@kaylabarnett thank you for the contribution! Could you add yourself as a contributor here: https://github.com/kaylabarnett/terra-toolkit/blob/main/CONTRIBUTORS.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaylabarnett thank you for the contribution! can we get someone with a windows machine to verify that this works?
It's always good to have additional verification. Another Windows consumer ran into this issue recently but I had not heard back from them whether or not it resolved their issue. I just reached out and they confirmed that this change did resolve their issue so we can also use this as verification. Note: The |
If we need additional verification I can reach out to my EPAM team to have them verify |
@kaylabarnett I think we're good as far as verification goes. |
Update poll command within waitForSeleniumHubReady to accommodate Windows users running WDIO tests
Summary
Made an update to the poll command within waitForSeleniumHubReady to use single quotes. This change was made as using double quotes is causing parsing issues when the method is executed on Windows machines. This was found during development via one of our EPAM teams.
Additional Details
Closes #663
@cerner/terra