This repository has been archived by the owner on May 22, 2024. It is now read-only.
[terra-functional-testing] Add useSeleniumStandalonService option #646
+70
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbcai
requested review from
dkasper-was-taken,
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
benbcai
commented
Apr 30, 2021
| @@ -143,6 +143,11 @@ const cli = { | |||
| describe: 'Whether or not to automatically update all reference screenshots with the latest screenshots.', | |||
| default: false, | |||
| }, | |||
| useSeleniumStandalonService: { | |||
There was a problem hiding this comment.
I'm open to suggestions if there is a better name to use.
There was a problem hiding this comment.
seems good enough to me
Suggested change
| useSeleniumStandalonService: { | |
| useSeleniumStandaloneService: { |
ShettyAkarsh
approved these changes
May 3, 2021
mjhenkes
reviewed
May 3, 2021
mjhenkes
reviewed
May 3, 2021
packages/terra-functional-testing/src/config/utils/getConfigurationOptions.js
Outdated
Show resolved
Hide resolved
mjhenkes
approved these changes
May 3, 2021
yuderekyu
reviewed
May 3, 2021
yuderekyu
approved these changes
May 3, 2021
Co-authored-by: Derek Yu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added
useSeleniumStandalonServiceoption to determine whether to use the standalone-chrome or the the selenium docker service when not using the selenium grid.Closes #637
Additional Details
gridUrlis not provided) to run wdio tests, Jenkins will now set theUSE_SELENIUM_STANDALONE_SERVICEenv variable to allow us to determine whether to use standalone-chrome as the hostname or start the selenium docker service. This is similar to how theCIenv is used in terra-toolkit-boneyard.useSeleniumStandalonServicein the CLI options documentation because consumers should not need to know about or set this locally since it should only be used by Jenkins.@cerner/terra