Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

[duplicate-package-checker-webpack-plugin] Support node 16 #730

Closed
wuifdesign opened this issue Feb 10, 2022 · 3 comments · Fixed by #731
Closed

[duplicate-package-checker-webpack-plugin] Support node 16 #730

wuifdesign opened this issue Feb 10, 2022 · 3 comments · Fixed by #731

Comments

@wuifdesign
Copy link

wuifdesign commented Feb 10, 2022

Bug Report

Description

Currently duplicate-package-checker-webpack-plugin has following entry in the package.json.

"engines": {
"node": "^10.0.0 || ^12.0.0 || ^14.0.0"
},

I think node 16 can be added safely otherwise you will get the following error on install:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@cerner/[email protected]',
npm WARN EBADENGINE   required: { node: '^10.0.0 || ^12.0.0 || ^14.0.0' },
npm WARN EBADENGINE   current: { node: 'v16.13.2', npm: '8.4.1' }
npm WARN EBADENGINE }
@boris-petrov
Copy link

Node 17 also.

@wuifdesign
Copy link
Author

wuifdesign commented Feb 10, 2022

maybe just this?

"node": "10 || 12 || 14 || >=16" 

@wuifdesign wuifdesign changed the title Support node 16 for duplicate-package-checker-webpack-plugin [duplicate-package-checker-webpack-plugin] Support node 16 Feb 10, 2022
zburke added a commit to folio-org/stripes-webpack that referenced this issue Feb 10, 2022
`@cerner/duplicate-package-checker-webpack-plugin` `2.2.0` introduced
new node engine restrictions without incrementing their major version.
Whoops. I suspect they didn't realize that their previous `>=10 || <13`
configuration short-circuited to `>=10`. Sigh.

Details: cerner/terra-toolkit#730

Refs STRWEB-35,
zburke added a commit to folio-org/stripes-webpack that referenced this issue Feb 10, 2022
`@cerner/duplicate-package-checker-webpack-plugin` `2.2.0` introduced
new node engine restrictions without incrementing their major version.
Whoops. I suspect they didn't realize that their previous `>=10 || <13`
configuration short-circuited to `>=10`. Sigh.

Details: cerner/terra-toolkit#730

Refs STRWEB-35,
@benbcai
Copy link
Contributor

benbcai commented Feb 11, 2022

@wuifdesign Thanks for reporting this issue. We will revert the change and get it released.

@benbcai benbcai self-assigned this Feb 11, 2022
zburke added a commit to folio-org/stripes-cli that referenced this issue Feb 11, 2022
`@folio/stripes-webpack` published `v3.0.3` to avoid bugs in a
dependency (cerner/terra-toolkit#730) so we
need to set `v3.0.3` as the minimum version here.
zburke added a commit to folio-org/stripes-cli that referenced this issue Feb 11, 2022
`@folio/stripes-webpack` published `v3.0.3` to avoid bugs in a
dependency (cerner/terra-toolkit#730) so we
need to set `v3.0.3` as the minimum version here.
zburke added a commit to folio-org/stripes-cli that referenced this issue Feb 11, 2022
`@folio/stripes-webpack` published `v3.0.3` to avoid bugs in a
dependency (cerner/terra-toolkit#730) so we
need to set `v3.0.3` as the minimum version here.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.