Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-form-select] Fixed IE issue that required two clicks to open the dropdown menu after initial selection. #2689

Merged
merged 10 commits into from
Oct 30, 2019
Merged

[terra-form-select] Fixed IE issue that required two clicks to open the dropdown menu after initial selection. #2689

merged 10 commits into from
Oct 30, 2019

Conversation

nramamurth
Copy link
Contributor

Summary

Fixes #2648

@bjankord bjankord temporarily deployed to terra-core-deployed-pr-2689 October 9, 2019 09:27 Inactive
@nramamurth nramamurth mentioned this pull request Oct 10, 2019
Closed
@nramamurth nramamurth marked this pull request as ready for review October 10, 2019 05:23
@nramamurth nramamurth self-assigned this Oct 10, 2019
@nramamurth nramamurth changed the title [WIP][terra-form-select] Fixed IE issue that required two clicks to open the dropdown menu after initial selection. [terra-form-select] Fixed IE issue that required two clicks to open the dropdown menu after initial selection. Oct 10, 2019
emilyrohrbough
emilyrohrbough reviewed Oct 22, 2019
View reviewed changes
Copy link
Contributor

@emilyrohrbough emilyrohrbough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you describe the tests to test these changes? Which of our current test are validating this behavior is being tested?

@nramamurth
Copy link
Contributor Author

nramamurth commented Oct 23, 2019 •
edited
Loading

@emilyrohrbough

Can you describe the tests to test these changes?

If you're talking about the steps to functionally verify on the deployed site, then following the steps mentioned here on IE should do.

Which of our current test are validating this behavior is being tested?

I did not see any but I have added one. However, this test might come handy when IE tests are run (probably in the future).

Naveen Kumar Ramamurthy added 2 commits October 30, 2019 17:59
Merge branch 'master' into form-select-ie
5a4d999 
# Conflicts:
#	packages/terra-form-select/CHANGELOG.md
#	packages/terra-form-select/src/single/Frame.jsx
Update doc.
5ba46cb
@ryanthemanuel ryanthemanuel merged commit a427964 into master Oct 30, 2019
@ryanthemanuel ryanthemanuel deleted the form-select-ie branch October 30, 2019 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emilyrohrbough emilyrohrbough emilyrohrbough left review comments

@StephenEsser StephenEsser StephenEsser approved these changes

@supreethmr supreethmr supreethmr approved these changes

@lokesh-0813 lokesh-0813 lokesh-0813 approved these changes

@avinashg1994 avinashg1994 avinashg1994 approved these changes

@bjankord bjankord Awaiting requested review from bjankord

@mjhenkes mjhenkes Awaiting requested review from mjhenkes

@ryanthemanuel ryanthemanuel Awaiting requested review from ryanthemanuel

@tbiethman tbiethman Awaiting requested review from tbiethman

@pranav300 pranav300 Awaiting requested review from pranav300

@saket2403 saket2403 Awaiting requested review from saket2403

@ShettyAkarsh ShettyAkarsh Awaiting requested review from ShettyAkarsh

@dkasper-was-taken dkasper-was-taken Awaiting requested review from dkasper-was-taken

Assignees

@StephenEsser StephenEsser

@nramamurth nramamurth

Labels
bug-fix 📦 terra-form-select
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[terra-form-select] Drop-down does not open on IE 11 after initial selection
8 participants
@nramamurth @StephenEsser @supreethmr @emilyrohrbough @lokesh-0813 @avinashg1994 @bjankord @ryanthemanuel