Fix for Rails pluck Bug to Prevent Truncating UUIDs
#986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ast. See rails/rails#28044 for details.
|
This fixes another issue for me where we're unable to obtain the right id / column name for an included resource when using caching. For example, a |
|
This needs the existing tests to pass, and ideally a test that fails without the changes. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an upstream bug in rails (rails/rails#28044) that causes UUIDs to be truncated by the
pluckmethod's type casting. By aliasing each column as#{table_name}_#{column}we bypass the default type casting and preserve UUIDs in their full form.Since there are 3 active versions of jsonapi-resources (0.8.x, 0.9.x, 0.10.x) I wasn't sure which to base this fix against, since IMO it should be fixed in all versions. I went with 0.9.x for selfish reasons, but I'm happy to help port it to the other versions.