Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for V0.11 and Rails 7.1 #1420

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Fix tests for V0.11 and Rails 7.1 #1420

merged 4 commits into from
Nov 1, 2023

Conversation

lgebhardt
Copy link
Member

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@lgebhardt lgebhardt requested a review from bf4 November 1, 2023 14:12
bf4
bf4 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@bf4 bf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@bf4 bf4 mentioned this pull request Nov 1, 2023
Closed
12 tasks
@lgebhardt lgebhardt merged commit 26d280a into v0-11-dev Nov 1, 2023
39 checks passed
@lgebhardt lgebhardt deleted the v0-11-test-rails-7-1 branch November 1, 2023 14:21
lgebhardt added a commit that referenced this pull request Apr 18, 2024
@lgebhardt
Fix tests for V0.11 and Rails 7.1 (#1420)
ba643ac 
* Cleanup table definitions for Rails 7.1

* Test helper move require 'rails/test_help'

* Test helper add `config.hosts`

* Update test matrix to add rails 7.1 and remove ruby 2.6

Note: ruby 2.7 is also EOL, but I'm choosing to continue testing 2.7 for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bf4 bf4 bf4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgebhardt @bf4