Skip to content

Conversation

lgebhardt
Copy link
Member

Needed to avoid "DEPRECATION WARNING: Dangerous query method..."
See rails/rails#32995

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

Needed to avoid "DEPRECATION WARNING: Dangerous query method..."
See rails/rails#32995
@lgebhardt lgebhardt merged commit 18cb4f6 into master Nov 7, 2018
@lgebhardt lgebhardt deleted the arel_sql_pluck_fields branch February 11, 2019 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant