Allow pagination for nested resources but not for included resources #1165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist:
Fixes #1162. The issue is that nested resources as well as included resources use
find_related_monomorphic_fragments
in a similar fashion. If we query nested resources, we want pagination to have an effect on the nested resources. If we include resources (at least currently) we don't want the pagination for the main resource to have an effect on the included resources. Thus, we have to differentiate between the two cases.The issue in #1162 is that if some page of the main resource has only 1 resource, the condition to apply pagination (
source_rids.count == 1
) would be true and thus no includes are loaded.