Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Lint: Fix lint errors caused by revive check for unused parameters #959

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

manishym
Copy link
Contributor

@manishym manishym commented Feb 13, 2024

revive v1.3.7 added mgechev/revive#966 which checks for unused parameters in function literals. This caused several lint errors in go-ceph code.

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

New or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.

The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with @Mergifyio rebase to rebase your PR when github indicates that the PR is out of date with the base branch.

revive v1.3.7 added mgechev/revive#966 which
checks for unused parameters in function literals. This caused several
lint errors in go-ceph code.

Signed-off-by: Manish <[email protected]>
@ansiwen ansiwen added the no-API This PR does not include any changes to the public API of a go-ceph package label Feb 13, 2024
Copy link
Collaborator

@ansiwen ansiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing these chores!

@mergify mergify bot merged commit 6f90ce1 into ceph:master Feb 13, 2024
15 checks passed
@@ -26,7 +26,7 @@ type User struct {
UserQuota QuotaSpec `json:"user_quota"`
TempURLKeys []interface{} `json:"temp_url_keys"`
Type string `json:"type"`
MfaIds []interface{} `json:"mfa_ids"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, damn, I missed this one. We can't change that. That's external API. I will make a fix-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants