Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: document PR raising process #788

Merged
merged 1 commit into from
Jan 23, 2025
Merged

README: document PR raising process #788

merged 1 commit into from
Jan 23, 2025

Conversation

ljflores
Copy link
Member

No description provided.

@ljflores ljflores requested a review from djgalloway January 16, 2025 16:30
@djgalloway
Copy link
Contributor

Let's see if we can get an e-mail address or something for the newly-created ceph.io approver list (you and me) instead of recommending contacting anyone in the Ceph org.

jmundack
jmundack reviewed Jan 16, 2025
View reviewed changes
README.md Outdated
Report any website issues you experience by email to **Mike Perez** <[email protected]>, *Ceph Community Manager*. Please include a brief description of the problem and a link that led to it.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be create a github issue? vs email Mike?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't update this line; I think GH flagged it since it got reformatted or something. Yeah, it can probably be rephrased to GH issues.

@gauravsitlani
Copy link
Member

Let's see if we can get an e-mail address or something for the newly-created ceph.io approver list (you and me) instead of recommending contacting anyone in the Ceph org.

Hi @djgalloway can I be added to the approver list as well?
I can help out regarding the same.

@ljflores
Copy link
Member Author

Let's see if we can get an e-mail address or something for the newly-created ceph.io approver list (you and me) instead of recommending contacting anyone in the Ceph org.

I asked Dan and Adam if they can make one.

README: document PR-raising process
a448e16 
We should make it clearer to the community that
the change ultimately needs to be made by a member
of the Ceph organization.

Signed-off-by: Laura Flores <[email protected]>
@ljflores ljflores requested a review from jmundack January 16, 2025 23:36
@ljflores
Copy link
Member Author

Added an email address and replaced Mike's contact.

@djgalloway djgalloway merged commit c9c85ad into ceph:main Jan 23, 2025
1 check passed
@ljflores ljflores deleted the wip-update-readme branch January 23, 2025 18:29
@ljflores
Copy link
Member Author

Let's see if we can get an e-mail address or something for the newly-created ceph.io approver list (you and me) instead of recommending contacting anyone in the Ceph org.

Hi @djgalloway can I be added to the approver list as well? I can help out regarding the same.

@gauravsitlani btw you were added to the list. You may still need to subscribe to it though: https://lists.ceph.io/postorius/lists/ceph-website.ceph.io/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djgalloway djgalloway djgalloway approved these changes

@jmundack jmundack Awaiting requested review from jmundack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ljflores @djgalloway @gauravsitlani @jmundack