-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebase: update csi-resizer to v1.13.1 #5071
rebase: update csi-resizer to v1.13.1 #5071
Conversation
/test ci/centos/k8s-e2e-external-storage/1.32 |
/test ci/centos/mini-e2e-helm/k8s-1.30 |
/test ci/centos/mini-e2e/k8s-1.31 |
It seems the new container-image is not available in the registry yet. |
d24e408
to
c8bfab2
Compare
v1.13.0 failed to build and could not be pushed to the release repository, v1.13.1 contains the release-tools fixes and is now available. |
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
c8bfab2
to
9a64ee4
Compare
/test ci/centos/upgrade-tests-cephfs |
/test ci/centos/upgrade-tests-rbd |
/test ci/centos/k8s-e2e-external-storage/1.30 |
/test ci/centos/k8s-e2e-external-storage/1.32 |
/test ci/centos/k8s-e2e-external-storage/1.31 |
/test ci/centos/mini-e2e-helm/k8s-1.30 |
/test ci/centos/mini-e2e-helm/k8s-1.32 |
/test ci/centos/mini-e2e-helm/k8s-1.31 |
/test ci/centos/mini-e2e/k8s-1.30 |
/test ci/centos/mini-e2e/k8s-1.32 |
/test ci/centos/mini-e2e/k8s-1.31 |
Pull request has been modified.
scripts/k8s-storage/driver-rbd.yaml
Outdated
# Support for volume expansion in controllers | ||
controllerExpansion: true | ||
# Support for volume expansion in controllers (only for RBD with BlockMode) | ||
controllerExpansion: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nixpanic we still need this to set to true for filesystem as well as it needs both controllerExpansion and filesystem resize as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/kubernetes/kubernetes/blob/ec2e0de35a298363872897e5904501b029817af3/test/e2e/storage/framework/testdriver.go#L193 this need to be set to false as its enabled by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, the options are a bit confusing, and their documentation could be better... I now found an offlineExpansion option, maybe that is more suitable.
/test ci/centos/k8s-e2e-external-storage/1.32 |
3c37350
to
dbb2cd3
Compare
/test ci/centos/k8s-e2e-external-storage/1.32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at d996439 |
The Kubernetes CSI community has released an updated external-resizer sidecar that fixes some issues and adds a few improvements. See: https://github.com/kubernetes-csi/external-resizer/releases/tag/v1.13.1 Signed-off-by: Niels de Vos <[email protected]>
The `offlineExpansion` option enables tests that try to expand volumes in the CSI Controller (provisioner). This is only possible for BlockMode volumes, as a FileMode volume needs run a filesystem resizer while the volume is attached. Signed-off-by: Niels de Vos <[email protected]>
dbb2cd3
to
e987e26
Compare
/test ci/centos/upgrade-tests-cephfs |
/test ci/centos/upgrade-tests-rbd |
/test ci/centos/k8s-e2e-external-storage/1.31 |
/test ci/centos/mini-e2e-helm/k8s-1.31 |
/test ci/centos/k8s-e2e-external-storage/1.32 |
/test ci/centos/k8s-e2e-external-storage/1.30 |
/test ci/centos/mini-e2e/k8s-1.31 |
/test ci/centos/mini-e2e-helm/k8s-1.32 |
/test ci/centos/mini-e2e-helm/k8s-1.30 |
/test ci/centos/mini-e2e/k8s-1.32 |
/test ci/centos/mini-e2e/k8s-1.30 |
The Kubernetes CSI community has released an updated external-resizer
sidecar that fixes some issues and adds a few improvements.
See: https://github.com/kubernetes-csi/external-resizer/releases/tag/v1.13.1