Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase: update csi-resizer to v1.13.1 #5071

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

nixpanic
Copy link
Member

@nixpanic nixpanic commented Jan 10, 2025

The Kubernetes CSI community has released an updated external-resizer
sidecar that fixes some issues and adds a few improvements.

See: https://github.com/kubernetes-csi/external-resizer/releases/tag/v1.13.1

@mergify mergify bot added the rebase update the version of an external component label Jan 10, 2025
@nixpanic nixpanic added the ci/skip/multi-arch-build skip building on multiple architectures label Jan 10, 2025
@nixpanic
Copy link
Member Author

/test ci/centos/k8s-e2e-external-storage/1.32

@nixpanic
Copy link
Member Author

/test ci/centos/mini-e2e-helm/k8s-1.30

@nixpanic
Copy link
Member Author

/test ci/centos/mini-e2e/k8s-1.31

Madhu-1
Madhu-1 previously approved these changes Jan 10, 2025
@Madhu-1 Madhu-1 requested a review from a team January 10, 2025 12:54
@nixpanic
Copy link
Member Author

It seems the new container-image is not available in the registry yet.

@nixpanic nixpanic force-pushed the sidecars/external-resizer/v1.13.0 branch from d24e408 to c8bfab2 Compare January 14, 2025 08:37
@nixpanic nixpanic changed the title rebase: update csi-resizer to v1.13.0 rebase: update csi-resizer to v1.13.1 Jan 14, 2025
@mergify mergify bot dismissed Madhu-1’s stale review January 14, 2025 08:38

Pull request has been modified.

@nixpanic
Copy link
Member Author

It seems the new container-image is not available in the registry yet.

v1.13.0 failed to build and could not be pushed to the release repository, v1.13.1 contains the release-tools fixes and is now available.

Madhu-1
Madhu-1 previously approved these changes Jan 14, 2025
@Madhu-1 Madhu-1 requested a review from a team January 14, 2025 08:43
Rakshith-R
Rakshith-R previously approved these changes Jan 15, 2025
@nixpanic
Copy link
Member Author

@Mergifyio queue

Copy link
Contributor

mergify bot commented Jan 15, 2025

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@nixpanic nixpanic force-pushed the sidecars/external-resizer/v1.13.0 branch from c8bfab2 to 9a64ee4 Compare January 15, 2025 09:21
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Jan 15, 2025
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@mergify mergify bot dismissed stale reviews from Madhu-1 and Rakshith-R January 15, 2025 15:26

Pull request has been modified.

# Support for volume expansion in controllers
controllerExpansion: true
# Support for volume expansion in controllers (only for RBD with BlockMode)
controllerExpansion: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nixpanic we still need this to set to true for filesystem as well as it needs both controllerExpansion and filesystem resize as well?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, the options are a bit confusing, and their documentation could be better... I now found an offlineExpansion option, maybe that is more suitable.

@nixpanic
Copy link
Member Author

/test ci/centos/k8s-e2e-external-storage/1.32

@nixpanic nixpanic force-pushed the sidecars/external-resizer/v1.13.0 branch from 3c37350 to dbb2cd3 Compare January 15, 2025 15:35
@nixpanic
Copy link
Member Author

/test ci/centos/k8s-e2e-external-storage/1.32

Copy link
Collaborator

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scripts/k8s-storage/driver-rbd.yaml Show resolved Hide resolved
@Madhu-1 Madhu-1 requested a review from a team January 16, 2025 09:12
@Rakshith-R
Copy link
Contributor

@Mergifyio queue

Copy link
Contributor

mergify bot commented Jan 17, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d996439

The Kubernetes CSI community has released an updated external-resizer
sidecar that fixes some issues and adds a few improvements.

See: https://github.com/kubernetes-csi/external-resizer/releases/tag/v1.13.1
Signed-off-by: Niels de Vos <[email protected]>
The `offlineExpansion` option enables tests that try to expand volumes
in the CSI Controller (provisioner). This is only possible for BlockMode
volumes, as a FileMode volume needs run a filesystem resizer while the
volume is attached.

Signed-off-by: Niels de Vos <[email protected]>
@nixpanic nixpanic force-pushed the sidecars/external-resizer/v1.13.0 branch from dbb2cd3 to e987e26 Compare January 17, 2025 06:54
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Jan 17, 2025
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jan 17, 2025
@mergify mergify bot merged commit d996439 into ceph:devel Jan 17, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip/multi-arch-build skip building on multiple architectures rebase update the version of an external component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants