osd: always allow setting target_size_ratio #6471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't prevent from setting target_size_ratio when the autoscaler is set to 'warn'. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1906305 Signed-off-by: Guillaume Abrioux <[email protected]>
clwluvw
added a commit
to clwluvw/ceph-ansible
that referenced
this pull request
Apr 25, 2022
when we set target_size_ratio to warn it means that the administrator wants to get suggestion from the mgr module but apply it manually when he/she wants. So it's in the same approach as 'on' mode just triggered by hand. So there is no need to set pg_num when target_size_ratio is 'warn' and the mgr module will calculate the correct pg_num and the administrator will adjust it whenever he/she wants. It is the same approach that was in ceph#6471 Signed-off-by: Seena Fallah <[email protected]>
guits
pushed a commit
that referenced
this pull request
May 31, 2022
when we set target_size_ratio to warn it means that the administrator wants to get suggestion from the mgr module but apply it manually when he/she wants. So it's in the same approach as 'on' mode just triggered by hand. So there is no need to set pg_num when target_size_ratio is 'warn' and the mgr module will calculate the correct pg_num and the administrator will adjust it whenever he/she wants. It is the same approach that was in #6471 Signed-off-by: Seena Fallah <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
May 31, 2022
when we set target_size_ratio to warn it means that the administrator wants to get suggestion from the mgr module but apply it manually when he/she wants. So it's in the same approach as 'on' mode just triggered by hand. So there is no need to set pg_num when target_size_ratio is 'warn' and the mgr module will calculate the correct pg_num and the administrator will adjust it whenever he/she wants. It is the same approach that was in #6471 Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit bb849a5)
mergify bot
pushed a commit
that referenced
this pull request
May 31, 2022
when we set target_size_ratio to warn it means that the administrator wants to get suggestion from the mgr module but apply it manually when he/she wants. So it's in the same approach as 'on' mode just triggered by hand. So there is no need to set pg_num when target_size_ratio is 'warn' and the mgr module will calculate the correct pg_num and the administrator will adjust it whenever he/she wants. It is the same approach that was in #6471 Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit bb849a5)
guits
pushed a commit
that referenced
this pull request
Jun 2, 2022
when we set target_size_ratio to warn it means that the administrator wants to get suggestion from the mgr module but apply it manually when he/she wants. So it's in the same approach as 'on' mode just triggered by hand. So there is no need to set pg_num when target_size_ratio is 'warn' and the mgr module will calculate the correct pg_num and the administrator will adjust it whenever he/she wants. It is the same approach that was in #6471 Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit bb849a5)
guits
pushed a commit
that referenced
this pull request
Jun 7, 2022
when we set target_size_ratio to warn it means that the administrator wants to get suggestion from the mgr module but apply it manually when he/she wants. So it's in the same approach as 'on' mode just triggered by hand. So there is no need to set pg_num when target_size_ratio is 'warn' and the mgr module will calculate the correct pg_num and the administrator will adjust it whenever he/she wants. It is the same approach that was in #6471 Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit bb849a5)
guits
pushed a commit
that referenced
this pull request
Jun 15, 2022
when we set target_size_ratio to warn it means that the administrator wants to get suggestion from the mgr module but apply it manually when he/she wants. So it's in the same approach as 'on' mode just triggered by hand. So there is no need to set pg_num when target_size_ratio is 'warn' and the mgr module will calculate the correct pg_num and the administrator will adjust it whenever he/she wants. It is the same approach that was in #6471 Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit bb849a5)
guits
pushed a commit
that referenced
this pull request
Jun 15, 2022
when we set target_size_ratio to warn it means that the administrator wants to get suggestion from the mgr module but apply it manually when he/she wants. So it's in the same approach as 'on' mode just triggered by hand. So there is no need to set pg_num when target_size_ratio is 'warn' and the mgr module will calculate the correct pg_num and the administrator will adjust it whenever he/she wants. It is the same approach that was in #6471 Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit bb849a5)
guits
pushed a commit
that referenced
this pull request
Jun 22, 2022
when we set target_size_ratio to warn it means that the administrator wants to get suggestion from the mgr module but apply it manually when he/she wants. So it's in the same approach as 'on' mode just triggered by hand. So there is no need to set pg_num when target_size_ratio is 'warn' and the mgr module will calculate the correct pg_num and the administrator will adjust it whenever he/she wants. It is the same approach that was in #6471 Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit bb849a5)
stuartgrace-bbc
pushed a commit
to bbc/ceph-ansible
that referenced
this pull request
Jan 30, 2024
when we set target_size_ratio to warn it means that the administrator wants to get suggestion from the mgr module but apply it manually when he/she wants. So it's in the same approach as 'on' mode just triggered by hand. So there is no need to set pg_num when target_size_ratio is 'warn' and the mgr module will calculate the correct pg_num and the administrator will adjust it whenever he/she wants. It is the same approach that was in ceph#6471 Signed-off-by: Seena Fallah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't prevent from setting target_size_ratio when the autoscaler
is set to 'warn'.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1906305
Signed-off-by: Guillaume Abrioux [email protected]