Disable creation#11
Merged
Merged
Conversation
Contributor
|
@mikiquantum would removing this extrinsic changes/breaks the metadata and makes the signer unusable? If so, I was thinking we could keep the extrinsic as is but just error out with a helpful error message and do a metadata update once we add the proxy pallet in. WDYT ? |
Contributor
Author
|
@vedhavyas I like that approach too, I would then create an empty extrinsic function that returns a useful error. Since I am not sure if that would affect the parity signer, although in any case, that would need to be updated with the bundle of RC3 I believe. |
vedhavyas
approved these changes
Aug 17, 2020
mikiquantum
commented
Aug 17, 2020
|
|
||
| # Remove Cargo.lock from gitignore if creating an executable, leave it for libraries | ||
| # More information here https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html | ||
| Cargo.lock |
Contributor
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commented multi-account creation extrinsic code.
Ensuring tests still pass by keeping the create function as internal only, for smoother transition.