peerInfo: Use U32 instead of BlockNumber#288
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
==========================================
+ Coverage 69.38% 69.41% +0.02%
==========================================
Files 130 130
Lines 6732 6732
==========================================
+ Hits 4671 4673 +2
+ Misses 1360 1359 -1
+ Partials 701 700 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
yrong
added a commit
to Snowfork/go-substrate-rpc-client
that referenced
this pull request
Feb 19, 2023
yrong
added a commit
to Snowfork/go-substrate-rpc-client
that referenced
this pull request
Mar 7, 2023
* Fix test: cherry pick centrifuge#288 from centrifuge * For #12345 from substrate * Add OptionalSignedCommitment * Remove obsolete marshalling code * MMR: #12345 and #12530 from substrate * Fix for ci * Use optional param instead * Bump substrate image * Disable breaking test for ci --------- Co-authored-by: Vincent Geddes <vincent@snowfork.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue reported on discord by one of our users. Was able to confirm the error caused by the incorrect type.