Skip to content

dev: Add orml_asset_registry#829

Merged
NunoAlexandre merged 1 commit into
parachainfrom
feat/asset-registry
Jun 17, 2022
Merged

dev: Add orml_asset_registry#829
NunoAlexandre merged 1 commit into
parachainfrom
feat/asset-registry

Conversation

@NunoAlexandre

@NunoAlexandre NunoAlexandre commented Jun 3, 2022

Copy link
Copy Markdown
Contributor

Part 1/2 of #825

development
  • Add orml-asset-registry pallet to dependencies
  • Add orml_asset_registry pallet to the development runtime
  • Try and use CurrencyId as the AssetId type of this pallet
  • Implement mock AssetProcessor
  • Add CurrencyId::ForeignAsset variant
  • Test that we can register the native as well as new foreign asset tokens
  • Adapt the XCM config to make use of this registry
general

@NunoAlexandre NunoAlexandre self-assigned this Jun 3, 2022

@NunoAlexandre NunoAlexandre left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important notes for reviewers 👇

Comment thread runtime/altair/src/lib.rs Outdated
Comment thread libs/common-types/src/tokens.rs
Comment thread pallets/loans/Cargo.toml Outdated
Comment thread runtime/altair/src/xcm.rs Outdated
@NunoAlexandre NunoAlexandre marked this pull request as ready for review June 14, 2022 08:16
@NunoAlexandre

Copy link
Copy Markdown
Contributor Author

@mikiquantum @offerijns please have a careful look at this. Check the todo list in the PR description and at the comments I left in my self-review with callouts to specific changes where your take is specially important.

@NunoAlexandre NunoAlexandre requested a review from branan June 14, 2022 08:30

@NunoAlexandre NunoAlexandre left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviews, please have a look 👇

Comment thread runtime/common/src/lib.rs
Comment thread runtime/development/src/lib.rs
hieronx
hieronx previously approved these changes Jun 14, 2022

@hieronx hieronx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! Will be much more manageable than the current setup 🔥

Comment thread libs/common-types/src/tokens.rs
Comment thread runtime/common/src/lib.rs Outdated
Comment thread runtime/common/src/lib.rs
@NunoAlexandre

Copy link
Copy Markdown
Contributor Author

@offerijns thanks for the review! I have addressed the loose ends and have dried two shared implementations cross-runtimes but no semantics changed have taken place since your last review. Can you have another look?

Comment thread runtime/common/src/impls.rs
@NunoAlexandre NunoAlexandre requested a review from hieronx June 15, 2022 15:02

@mikiquantum mikiquantum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, I have a few questions, forgive me if I am late to the party on those.

I think EnsureRootOr<HalfOfCouncil> is fine.

🙏

Comment thread libs/common-types/src/tokens.rs
Comment thread runtime/altair/src/xcm.rs Outdated
Comment thread runtime/common/src/impls.rs
Comment thread runtime/common/src/lib.rs
Comment thread runtime/altair/src/lib.rs Outdated
Comment thread runtime/common/src/impls.rs
Comment thread Cargo.toml
]
runtime-benchmarks = [
"frame-benchmarking/runtime-benchmarks",
"frame-system/runtime-benchmarks",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add this here because we need the runtime-benchmarks flag to be available for runtime-common

@NunoAlexandre NunoAlexandre changed the title feat: Add orml_asset_registry dev: Add orml_asset_registry Jun 16, 2022
@NunoAlexandre NunoAlexandre merged commit f1b6c44 into parachain Jun 17, 2022
@NunoAlexandre NunoAlexandre deleted the feat/asset-registry branch June 17, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants