dev: Add orml_asset_registry#829
Conversation
NunoAlexandre
left a comment
There was a problem hiding this comment.
Important notes for reviewers 👇
|
@mikiquantum @offerijns please have a careful look at this. Check the todo list in the PR description and at the comments I left in my self-review with callouts to specific changes where your take is specially important. |
NunoAlexandre
left a comment
There was a problem hiding this comment.
Reviews, please have a look 👇
b08de60 to
df7d65b
Compare
hieronx
left a comment
There was a problem hiding this comment.
This looks really good! Will be much more manageable than the current setup 🔥
|
@offerijns thanks for the review! I have addressed the loose ends and have dried two shared implementations cross-runtimes but no semantics changed have taken place since your last review. Can you have another look? |
mikiquantum
left a comment
There was a problem hiding this comment.
Overall looks good, I have a few questions, forgive me if I am late to the party on those.
I think EnsureRootOr<HalfOfCouncil> is fine.
🙏
9d874de to
2805b82
Compare
| ] | ||
| runtime-benchmarks = [ | ||
| "frame-benchmarking/runtime-benchmarks", | ||
| "frame-system/runtime-benchmarks", |
There was a problem hiding this comment.
We need to add this here because we need the runtime-benchmarks flag to be available for runtime-common
2805b82 to
8a4230e
Compare
8a4230e to
96114a7
Compare
orml_asset_registryorml_asset_registry
Part 1/2 of #825
development
orml-asset-registrypallet to dependenciesorml_asset_registrypallet to the development runtimeCurrencyIdas theAssetIdtype of this palletAssetProcessorCurrencyId::ForeignAssetvariantgeneral
asset-registry: Pass Asset Id to AuthorityOrigin open-web3-stack/open-runtime-module-library#762
asset-registry: And and Implement
Inspect+Mutatetraits open-web3-stack/open-runtime-module-library#767TokenMetadatatraitSee commit description
CustomMetadataSee dev: Add
orml_asset_registry#829 (comment)CurrencyId::Permissioned