Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add new oracle key #1841

Merged
merged 1 commit into from
May 21, 2024
Merged

Feat: Add new oracle key #1841

merged 1 commit into from
May 21, 2024

Conversation

mustermeiszer
Copy link
Collaborator

Description

The DYF will have shares of other funds as its assets. Those fund holdings are valued by an oracle, but have not a valid registered ISIN we could use. Hence, this fallback key will allow to specifically value a given object in the pallet-loans.

Changes and Descriptions

  • Adds a new variant in enum OracleKey
  • Fixes all variants by using #[codec(index = ...)

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@mustermeiszer mustermeiszer added the D0-ready Pull request can be merged without special precaution and notification. label May 21, 2024
@mustermeiszer mustermeiszer enabled auto-merge (squash) May 21, 2024 13:18
@mustermeiszer mustermeiszer requested a review from lemunozm May 21, 2024 13:18
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.84%. Comparing base (ba41880) to head (68d40ff).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1841      +/-   ##
==========================================
- Coverage   46.87%   46.84%   -0.03%     
==========================================
  Files         165      165              
  Lines       12950    12950              
==========================================
- Hits         6070     6067       -3     
- Misses       6880     6883       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mustermeiszer mustermeiszer merged commit 5fc0465 into main May 21, 2024
14 checks passed
@lemunozm lemunozm deleted the feat/new-oracle-key branch May 21, 2024 18:53
@wischli wischli added the D5-breaks-api Pull request changes public api. Document changes publicly. label May 30, 2024
@wischli wischli added this to the Centrifuge 1029 milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D0-ready Pull request can be merged without special precaution and notification. D5-breaks-api Pull request changes public api. Document changes publicly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants