Fix: transfer debt event with updated repaid amount #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
added
I2-bug
hieronx
reviewed
May 16, 2024
wischli
previously approved these changes
May 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1837 +/- ##
==========================================
- Coverage 46.91% 46.88% -0.04%
==========================================
Files 165 165
Lines 12950 12950
==========================================
- Hits 6076 6071 -5
- Misses 6874 6879 +5 ☔ View full report in Codecov by Sentry. |
|
Sure! I always forget to test events properly, and I should. |
mustermeiszer
approved these changes
May 17, 2024
gpmayorga
pushed a commit
that referenced
this pull request
May 17, 2024
* fix transfer debt event with updated repaid amount * add tests for checking repay events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TransferEventwas set with the initialrepaid_amount. That amount changes once it is processed and could not be the amount that it's really applied.