fix: pool fee event dispatch order

[wischli]

Description

• Context: https://centrifugedao.slack.com/archives/C04R42WGM7U/p1710854795914679
• Changes event order dispatch of pool creation and pool fees added when creating a new pool: Fee event needs to be after pool creation one

Checklist:

• I have added Rust doc comments to structs, enums, traits and functions
• I have made corresponding changes to the documentation
• I have performed a self-review of my code
• I have added tests that prove my fix is effective or that my feature works

[lemunozm]

Clean and with its own test. Perfect!!

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 48.58%. Comparing base (66624fd) to head (7cbcc87).

Files	Patch %	Lines
pallets/pool-system/src/impls.rs	82.35%	3 Missing ⚠️
pallets/pool-system/src/lib.rs	50.00%	2 Missing ⚠️
pallets/pool-system/src/pool_types.rs	89.47%	2 Missing ⚠️
pallets/pool-registry/src/lib.rs	87.50%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1809      +/-   ##
==========================================
+ Coverage   48.56%   48.58%   +0.02%     
==========================================
  Files         168      168              
  Lines       13344    13359      +15     
==========================================
+ Hits         6480     6490      +10     
- Misses       6864     6869       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hieronx]

Changes re the pool fee event look good!

Something I realized that is completely unrelated to this PR, but was looking at the pool-registry code: shouldn't we emit an MetadataSet event here:

centrifuge-chain/pallets/pool-registry/src/lib.rs

Line 289 in 9618071

PoolMetadata::<T>::insert(

Now we are only emitting it on updates, which makes tracking all metadata harder as you need separate logic to track the first one.

If we do that, we should emit this event after the T::ModifyPool::create call

[hieronx]

Should we move the T::AssetRegistry::register_asset calls in the loop also to below the PoolSystem::Created event? Not an issue now, but I can imagine this also creating issues down the road

[wischli]

Should we move the T::AssetRegistry::register_asset calls in the loop also to below the PoolSystem::Created event? Not an issue now, but I can imagine this also creating issues down the road

Definitely! 41d56aa

[wischli]

Changes re the pool fee event look good!

Something I realized that is completely unrelated to this PR, but was looking at the pool-registry code: shouldn't we emit an MetadataSet event here:

centrifuge-chain/pallets/pool-registry/src/lib.rs

Line 289 in 9618071

PoolMetadata::<T>::insert(

Now we are only emitting it on updates, which makes tracking all metadata harder as you need separate logic to track the first one.
If we do that, we should emit this event after the T::ModifyPool::create call

Thanks for raising this. Fixed in #1811

Seems like this should be added after the Registered event. I can imagine there will be more events for which we should change the dispatch order for SubQuery in the near future.

[lemunozm]

LGTM!!