Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock builder: use foss3 dependency #1592

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Mock builder: use foss3 dependency #1592

merged 2 commits into from
Oct 16, 2023

Conversation

lemunozm
Copy link
Contributor

@lemunozm lemunozm commented Oct 16, 2023

Description

Removes the inner mock-builder dependency and uses the foss3 dependency.

@NunoAlexandre a version of 0.9.43 is already available for foss3 when you need to update the dependency: https://github.com/foss3/runtime-pallet-library/tree/polkadot-v0.9.43

Fixes #1591

@lemunozm lemunozm added Q0-trivial An issure which is similar to patching code. P5-soon Issue should be addressed soon. I6-refactoring Code needs refactoring. dependencies Pull requests that update a dependency file. labels Oct 16, 2023
@lemunozm lemunozm self-assigned this Oct 16, 2023
Copy link
Contributor

@NunoAlexandre NunoAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👌

Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at that huge block of removed lines feels awesome!

@@ -23,7 +23,7 @@ sp-std = { git = "https://github.com/paritytech/substrate", default-features = f
[dev-dependencies]
cfg-mocks = { path = "../mocks" }
cfg-types = { path = "../types" }
mock-builder = { path = "../../libs/mock-builder" }
mock-builder = { workspace = true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When @NunoAlexandre ends with the update I wanted to do it massively in all our repo

@lemunozm lemunozm merged commit 5e80739 into main Oct 16, 2023
10 checks passed
@lemunozm lemunozm deleted the mock-builder/from-foss3 branch October 16, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. I6-refactoring Code needs refactoring. P5-soon Issue should be addressed soon. Q0-trivial An issure which is similar to patching code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MockBuilder: use dependency from foss3 repo
3 participants