Add loans to centrifuge runtime#1254
Merged
mustermeiszer merged 2 commits intoMar 23, 2023
Merged
Conversation
lemunozm
added
D2-notify
This was referenced Mar 14, 2023
lemunozm
force-pushed
the
feature/add-pools-to-centrifuge
branch
from
076849a to
8c89a16
Compare
lemunozm
force-pushed
the
feature/add-loans-to-centrifuge
branch
from
12636c9 to
5cbcf9f
Compare
Collaborator
|
@lemunozm I will rebase this one here on the latest |
mustermeiszer
force-pushed
the
feature/add-loans-to-centrifuge
branch
from
5cbcf9f to
68d61d5
Compare
mustermeiszer
requested review from
NunoAlexandre,
branan,
hieronx,
mikiquantum and
mustermeiszer
as code owners
mustermeiszer
approved these changes
Mar 23, 2023
mustermeiszer
left a comment
mustermeiszer
left a comment
Collaborator
There was a problem hiding this comment.
I will merge this into the feature branch although nix is failing. Will need to update there anyways. Changes here look sane.
hieronx
pushed a commit
that referenced
this pull request
Apr 4, 2023
* Add missing pallets to centrifuge - loans not yet
* Clean up feature list Centrifuge
* Add most pallets, not loans yet
* Add Keystore and Uniques to Centrifuge runtime
* TMP add pallet-loans
* Use per-pallet weights for unbenched pallets
* Add missing imports
* EnsureRoot<AccountId>
* Add remaining impls
* Restore Encode/Decode impls for MaxTranches
This is needed in order to make it available to the RPCs
* Add serde for conditional {De}serialize impls
* Add uniques/keystores to benchmarks
* Add interest_accrual to centrifuge genesis
* Fix PoolCreateOrigin for benchmarks
* Actually run all the benches
* Enable Pools RPC endpoints on centrifuge chain
* Adapt paramets from Jeroen suggestion
* fix: issuance issues for creating blocking redeem order
* change: Remove check in guard, updates note submission, not schedule
* Removing the check if the MinUpdateDelay is passed, as this is part of
the pallet-pool-system checks already
* ScheduledUpdateDetails now note the time of submission of an update
rather than the time when it is scheduled. logically, there is no "scheduled"
time as the update can still be blocked by redemptions or other stuff in the
future
* change: Remove impossible to fulfill check
The check in the update guard was checking whether the time of the
last closed epoch is larger than now. Which is impossible to fulfill.
Epochs can not be closed closed in the future if now is now...
* feat: Add correct check if epoch was closed in between
* fix: runtime settings altair, centrifuge for pool params
* fix: registry-benchmarks
* fix: uniques naming, feature guard for PoolUpdateGuard
* fix taplo & nix
* Adding filter for restricted tokens
* feat: new weights for centrifuge runtime
* feat: use newly benched weights
* feat: adapt parameters
* fix: adapt uniques parameters according to review
* Add loans to centrifuge runtime (#1254)
* add loans to centrifuge
* fix loan addition
* inter: clion deletes this files content, need to regenerate anyways
* fix: rm warn, check orml-asset-regsitry weights
* fix: collator-selection benchmarks
* fix: xcmp queue benches to centrifuge
* feat: intermediate change spec name for upgrade on charcoal
* fix: failing collator-allowlist test with benchmark fix
* feat: update nix hash
* fiy: clippy lint, allow for readabulity
* fix: xclippy allow not working, using suggestion
* fix: clippy development runtime
* feat: adapt weight to high fix
* feat: update weights centrifuge
* feat: Update weights altair
* fix: use weights, adapt comments
* fix: only signed origin in registry benches
* feat: Pump version number Centrifuge
* Update Cargo.toml centrifuge
* fix: remarks from review
* chore: bump nix
* fix: enable phrag elec benches in cfg runtime
* fix: remove old migrations, default to V2 interest accrual
* fix: typos, use dummy weight phragmen, prepare for bench
* fix: adapt nix hash
* chore: update weights centrifuge
---------
Co-authored-by: Branan Riley <branan@centrifuge.io>
Co-authored-by: lemunozm <lemunozm@gmail.com>
Co-authored-by: William Freudenberger <w.freude@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
pallet-loans-reftocentrifugeruntime.Fixes #1243
Changes and descriptions
Type of change