Re-calculating Virtual Memory for Windows machines #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jmpalomares Thanks A LOT for helping us improving centreon_plugins. We're aware of this problem for a while since SNMP on windows is shitty ... for a while :) Our decision is to strongly recommend to use our client plugins (nrpe or restapi) along the NSClient++ agent to monitor MS environment. Page file usage will be more accurate for such monitoring. We may address the problem as you did through this PR, but we would prefer that Windows fix its own issue and not hidding such issue with code. Anyway, I could understand that it's a problem to you to use an agent instead of SNMP. If so, it would be really cool to adapt yout PR by adding an option letting users choose to bypass or not this windows bug. (Also not changing running behaviour of the plugin that could trigger false-positives somewhere). IMOO, --wash-ms-hands would be a really hype name for such option =) |
Sims24
suggested changes
Mar 29, 2018
|
Thanks @jmpalomares, I will add the option. |
Sims24
added a commit
to Sims24/centreon-plugins
that referenced
this pull request
Aug 16, 2018
* + perl 5.10 & el6 compatibility (centreon#949) Fix centreon#945 * improve ntp mode empty ntp_hostname option (centreon#952) * Sonicwall plugin (centreon#922) * + add plugin for sonicwall Ref centreon#914 * Correcting mode formerly named 'traffic' to 'interfaces' (centreon#895) Closes centreon#895 * Enhance juniper ssg plugin (centreon#959) Closes centreon#891 * enhance juniper ssg plugin * fix key loop and hash init * List storages (centreon#946) * better response time & add posibility to know drive type * fix f5 bigip failover warning thresholds (centreon#964) Closes centreon#963 * add ssl opt harmonization (centreon#965) - Closes centreon#961 - enhance el7 perl ssl compatibility - add proxy option where missing * fix f5 bigip trunks (centreon#966) * add snmp_standard interfaces speed check (centreon#967) * refactor riverbed steelhead (centreon#971) * Closes centreon#970 * fix riverbed steelhead typo (centreon#972) * fix riverbed steelhead typo * prepare new release (centreon#973) * enhance http lib to handle hidden basic authent (centreon#974) * add basic option to mode using http lib (centreon#975) * fix f5 bigip trunks div by 0 error (centreon#977) Closes centreon#976 * enhance sonicwall plugin (centreon#978) * fix hirschmann psu wrong oid (centreon#985) * enhance quadstor vtltapeusage mode (centreon#987) * enhance quadstor vtltapeusage mode * init counter to 0 * [QOS] Cisco - Bug fix proposal (centreon#792) * Fix: Calcul total And Child * Fix: Put in 'variable' the name of the service-policy * Fix: child detection * prepare new release (centreon#998) * Cannot find physical memory informations fix centreon#994 (centreon#1000) * fix processcount perfdata output typos (centreon#1003) * refacto netapp qtreeusage and add not-kbytes option (centreon#1029) * fix qnap hardware thresholds overload (centreon#1028) * add cloudfoundry plugin (wip) (centreon#1031) * Filesystem Check (centreon#1036) * enh linux local mountpoint mode (centreon#1043) * enh selenium plugin (centreon#1039) * add silverpeak plugin (centreon#1037) * added silverpeak plugin and modes * fix type, oid name and timealarms * fix cache file name * starting peplink loadbalancer monitoring (centreon#1015) * Create memory.pm * Create cpu.pm * Create plugin.pm * fix peplink silverpeak plugins typos (centreon#1045) * fix peplink plugin typos * fix silverpeak plugin typos * report idrac installed CPUs only (centreon#1017) * Report installed CPUs only using processorDeviceTable instead of processorDeviceStatusTable * Report installed CPUs only, adapt var names * add database-size mode (centreon#870) * fix postgres databasesize mode (centreon#1046) * fix postgres databasesize mode, missing empty selection (centreon#1047) * fix arista memory output (centreon#1048) * enh h3c hardware cache (centreon#1049) * fix fortigate devicestatus help (centreon#1050) * fix dell fastpath temperature (centreon#1051) * fix hirschmann memory (centreon#1052) * fix tomcat web sessions (centreon#1053) * enh paloalto cluster output (centreon#1054) * convert blocked processes counters (centreon#938) * Convert database::mssql::mode::blockedprocesses to the counters library * Using fetchrow_hashref instead of fetchall_arrayref according to @Sims24 recommendation * Rationalizing a bit the output/long output/debug output * enh mssql blockedprocesses (centreon#1055) * adding new local plugin to os::hpux with two modes regarding disks (storage, inodes) (centreon#955) * adding new 'inodes' mode to os::aix::local::plugin (centreon#956) * enh aix local inodes (centreon#1056) * enh aix local inodes, wrong parsing (centreon#1057) * enh aix local storage inodes (centreon#1058) * correct RADIUS help (centreon#1060) * fix mssql blocked processes trim (centreon#1066) * fix mssql transactions case (centreon#1067) * adding Centos Upgrade Check (centreon#1034) * enh linux local pending updates (centreon#1068) * using a file a JSON source did not work (wrong file handler) (centreon#979) * re-calculating virtual memory for windows machines (centreon#929) * enh windows snmp swap (centreon#1069) * fix kaspersky snmp deployment devision by zero (centreon#1070) * enh windows snmp swap, help (centreon#1072) * enh windows snmp swap, physical memory name (centreon#1073) * fix netapp restapi volumeusage typo (centreon#1074) * enh sql sqlstring for dual tables (centreon#1075) * add slack plugin (centreon#1076)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the virtual memory for windows hosts are not correctly defined in windows machines with SNMP. When you do a request of OID .1.3.6.1.2.1.25.2.3.1.5 instead of gives you the INTEGER for the Virtual memory only, it gives you the sum of all the memory in the System (physycal + virtual)
I've edited the Swap module for windows OS in order to re-calculate the Virtual Memory correctly substracting the physical memory from the virtual memory (.1.3.6.1.2.1.25.2.3.1.5 and .1.3.6.1.2.1.25.2.3.1.6) in order to get the real Virtual Memory.