Skip to content

add boot_b mapping for ride4 boards#95

Merged
bkhizgiy merged 1 commit into
centos-automotive-suite:mainfrom
bennyz:map-boot-b
Feb 12, 2026
Merged

add boot_b mapping for ride4 boards#95
bkhizgiy merged 1 commit into
centos-automotive-suite:mainfrom
bennyz:map-boot-b

Conversation

@bennyz

@bennyz bennyz commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Enhanced boot partition handling for specific device targets to ensure proper multi-partition flashing.
    • Extended partition configuration support for additional device platforms.

Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
@coderabbitai

coderabbitai Bot commented Feb 11, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

This PR extends boot partition support for specific ride4* and ridesx4* targets. The push_artifact.sh script now duplicates boot_a files to boot_b for these targets during multi-layer artifact preparation, while partition rules configuration is updated to include boot_b in the partition include lists for affected targets.

Changes

Cohort / File(s) Summary
Boot Partition Duplication Logic
internal/common/tasks/scripts/push_artifact.sh
Adds target-specific boot partition duplication: for ride4* and ridesx4* targets, copies boot_a.* files to boot_b.* within the parts_dir processing if boot_b.* does not already exist, ensuring both boot partitions are available for flashing.
Partition Configuration Updates
internal/controller/operatorconfig/controller.go
Extends partition-rules.yaml configuration to add boot_b to the include lists for ridesx4, ridesx4_scmi, and ride4_sa8775p_sx_r3 targets alongside existing system_a, system_b, and boot_a partitions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 Two boots are better than one, you see,

Boot_a dupes to boot_b so merrily,

For ride4 and ridesx4 with care,

Both partitions flashing, a perfect pair! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly aligns with the main changes: adding boot_b mapping/configuration for ride4 and related board targets across both files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
internal/common/tasks/scripts/push_artifact.sh (1)

218-218: Nit: sed 's/boot_a/boot_b/' replaces the first occurrence in the full path, not just the filename.

If parts_dir ever contained the substring boot_a, the substitution would corrupt the path. Currently safe given the naming convention (${exportFile}-parts), but anchoring to the basename would be more defensive:

Suggested hardening
-        boot_b_file=$(echo "$boot_a_file" | sed 's/boot_a/boot_b/')
+        boot_b_file="${parts_dir}/$(basename "$boot_a_file" | sed 's/boot_a/boot_b/')"

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bennyz bennyz requested a review from bkhizgiy February 11, 2026 18:51
@bkhizgiy bkhizgiy merged commit 1a1c04f into centos-automotive-suite:main Feb 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants