Skip to content

add openshift version and remove bundle#85

Merged
bennyz merged 2 commits into
centos-automotive-suite:mainfrom
bennyz:operator-bundle
Feb 8, 2026
Merged

add openshift version and remove bundle#85
bennyz merged 2 commits into
centos-automotive-suite:mainfrom
bennyz:operator-bundle

Conversation

@bennyz

@bennyz bennyz commented Feb 8, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Removed operator bundle manifests including ClusterServiceVersion and CRD definitions
    • Removed RBAC roles, rolebindings and related metrics service
    • Removed scorecard test configuration
    • Added guard to bundle build to ensure OpenShift version annotation
    • Added bundle/ to .gitignore
    • Updated CI workflows to newer action versions and removed Go module cache steps

Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
@coderabbitai

coderabbitai Bot commented Feb 8, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

This PR removes the operator bundle (many bundle/manifests CRDs, CSV, RBAC, service, annotations, dependencies, and scorecard config), adds a Makefile guard to ensure com.redhat.openshift.versions exists in bundle metadata, and adds bundle/ to .gitignore.

Changes

Cohort / File(s) Summary
Git config & build
\.gitignore, Makefile
Adds bundle/ to .gitignore; Makefile: add guard that appends com.redhat.openshift.versions: v4.18-v4.21 to bundle/metadata/annotations.yaml if missing.
Bundle CSV
bundle/manifests/automotive-dev-operator.clusterserviceversion.yaml
Deletes the entire ClusterServiceVersion manifest for the operator.
Bundle CRDs
bundle/manifests/automotive.sdv.cloud.redhat.com_*.yaml
Removes CRD manifests for CatalogImage, ImageBuild, Image, and OperatorConfig (full schema/printer columns/subresources removed).
Bundle RBAC & bindings
bundle/manifests/ado-*-role*.yaml, bundle/manifests/ado-*-rolebinding*.yaml, bundle/manifests/ado-pipeline-*.yaml, bundle/manifests/ado-scc-*.yaml
Deletes multiple ClusterRole, Role, ClusterRoleBinding, and RoleBinding manifests (image/editor/viewer, imagebuild/editor/viewer, metrics auth, operator auth-delegator, pipeline/SCC bindings, etc.).
Bundle service & metadata
bundle/manifests/ado-operator-metrics-service_v1_service.yaml, bundle/metadata/annotations.yaml, bundle/metadata/dependencies.yaml, bundle/tests/scorecard/config.yaml
Removes operator metrics Service, bundle annotations block, a dependency entry (openshift-pipelines-operator-rh), and scorecard test configuration.
CI workflows
.github/workflows/build.yml, .github/workflows/e2e.yml, .github/workflows/lint.yml
Bumps some action versions in build.yml; removes Go module cache steps from e2e.yml and lint.yml.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

  • fix minKubeVersion #65 — Touches the same CSV (automotive-dev-operator.clusterserviceversion.yaml); changes to CSV metadata (minKubeVersion) overlap with this PR's CSV removal.
  • update CRDs to comply with catalog #62 — Adds com.redhat.openshift.versions to CSV metadata; directly related to the Makefile guard that ensures that annotation exists.
  • adjust imagebuild api #40 — Modifies the ImageBuild CRD; strongly related because this PR deletes the ImageBuild CRD manifest.

Poem

🐰 I hopped through folders, soft and spry,
Tidied manifests and watched CRDs fly,
Annotations tucked, the bundle hid away,
Gitignored paths where we used to play,
A tiny rabbit cheers: "Clean slate today!" 🌿

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title partially describes the changeset but lacks clarity about the primary objective. While 'add openshift version' aligns with the Makefile change, 'remove bundle' is vague—the PR actually removes numerous bundle manifests, metadata, tests, and workflow caching steps. Consider a more specific title such as 'Remove bundle manifests and add OpenShift version annotation' to better convey the complete scope of changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
.github/workflows/build.yml (1)

39-39: Consider pinning GitHub Actions to full commit SHAs instead of major version tags.

Using mutable tags like @v5, @v6 exposes the workflow to supply-chain attacks if a tag is force-pushed. Pinning to a specific SHA (e.g., docker/build-push-action@<sha>) with a version comment is the more secure practice recommended by GitHub. This is optional and can be deferred.

Also applies to: 68-68, 242-242, 271-271, 308-308


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
@bennyz bennyz merged commit 96e6325 into centos-automotive-suite:main Feb 8, 2026
4 checks passed
@bennyz bennyz deleted the operator-bundle branch February 8, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant