add support for tolerations#28
Merged
Merged
Conversation
so tasks can be assigned to nodes exclusively Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
vtz
added a commit
to vtz/automotive-dev-operator
that referenced
this pull request
Apr 11, 2026
CRD changes (softwarebuild_types.go): - Remove hostPath source type (not implemented) (centos-automotive-suite#7) - Add CEL validation for source type/field consistency (centos-automotive-suite#11) - Remove unused destination types (registry, artifactory, quay) (centos-automotive-suite#16) - Tighten Git URL and revision validation patterns (centos-automotive-suite#1) Pipeline generation (software_build.go): - Fix command injection: quote URL and revision in git clone (centos-automotive-suite#1) - Sanitize revision with regex, fall back to "main" on invalid input - Deterministic PipelineRun naming using sb.Generation (centos-automotive-suite#3) - Propagate TimeoutSeconds and BuildTimeoutMinutes to PipelineRun (centos-automotive-suite#6) - Add SecurityContext with AllowPrivilegeEscalation=false (centos-automotive-suite#12) - Wire per-stage image override (centos-automotive-suite#17) - Use ParseQuantity with fallback instead of MustParse (centos-automotive-suite#26) - Wire ServiceAccountName to PipelineRun (centos-automotive-suite#28) - Wire OperatorConfig DefaultImage through BuildConfig (centos-automotive-suite#14) Controller (softwarebuild/controller.go): - Handle status update errors instead of discarding them (centos-automotive-suite#8) - Distinguish Pending from Running using StartTime (centos-automotive-suite#18) - Add error context wrapping on all return paths (centos-automotive-suite#19) - Replace magic strings with typed constants (centos-automotive-suite#20) - Extract mapPipelineRunPhase and buildStageStatuses helpers (centos-automotive-suite#24) OperatorConfig controller: - Propagate deploySoftwareBuilds error and set Failed status (centos-automotive-suite#4) - Add cleanupSoftwareBuilds for when feature is disabled (centos-automotive-suite#5) - Wire SoftwareBuildsConfig fields to pipeline generation (centos-automotive-suite#14) Made-with: Cursor
vtz
added a commit
to vtz/automotive-dev-operator
that referenced
this pull request
Apr 11, 2026
CRD changes (softwarebuild_types.go): - Remove hostPath source type (not implemented) (centos-automotive-suite#7) - Add CEL validation for source type/field consistency (centos-automotive-suite#11) - Remove unused destination types (registry, artifactory, quay) (centos-automotive-suite#16) - Tighten Git URL and revision validation patterns (centos-automotive-suite#1) Pipeline generation (software_build.go): - Fix command injection: quote URL and revision in git clone (centos-automotive-suite#1) - Sanitize revision with regex, fall back to "main" on invalid input - Deterministic PipelineRun naming using sb.Generation (centos-automotive-suite#3) - Propagate TimeoutSeconds and BuildTimeoutMinutes to PipelineRun (centos-automotive-suite#6) - Add SecurityContext with AllowPrivilegeEscalation=false (centos-automotive-suite#12) - Wire per-stage image override (centos-automotive-suite#17) - Use ParseQuantity with fallback instead of MustParse (centos-automotive-suite#26) - Wire ServiceAccountName to PipelineRun (centos-automotive-suite#28) - Wire OperatorConfig DefaultImage through BuildConfig (centos-automotive-suite#14) Controller (softwarebuild/controller.go): - Handle status update errors instead of discarding them (centos-automotive-suite#8) - Distinguish Pending from Running using StartTime (centos-automotive-suite#18) - Add error context wrapping on all return paths (centos-automotive-suite#19) - Replace magic strings with typed constants (centos-automotive-suite#20) - Extract mapPipelineRunPhase and buildStageStatuses helpers (centos-automotive-suite#24) OperatorConfig controller: - Propagate deploySoftwareBuilds error and set Failed status (centos-automotive-suite#4) - Add cleanupSoftwareBuilds for when feature is disabled (centos-automotive-suite#5) - Wire SoftwareBuildsConfig fields to pipeline generation (centos-automotive-suite#14) Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so tasks can be assigned to nodes exclusively