fix flash cmd rendering

[bennyz]

the closing } was treated as a literal from the flash cmd string

Summary

Related Issues

Type of Change

• Bug fix
• New feature
• Breaking change
• Documentation update
• CI/CD improvement
• Refactoring

Testing

• Unit tests pass (make test)
• Linter passes (make lint)
• Manifests are up to date (make manifests generate)
• Tested on OpenShift cluster (if applicable)

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Enhanced image flashing process to properly handle custom configurations when explicitly specified versus using default values.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6bd3dabb-ffcf-4617-82f7-122bd62556a6

📥 Commits

Reviewing files that changed from the base of the PR and between d1662e4 and 1cd6fbc.

📒 Files selected for processing (1)

• internal/common/tasks/scripts/flash_image.sh

---

📝 Walkthrough

Walkthrough

The script's FLASH_CMD initialization logic now distinguishes between an explicitly provided empty value and an unset variable, allowing different default behavior for each case while preserving the subsequent substitution and flash flow.

Changes

Cohort / File(s)	Summary
Flash command initialization internal/common/tasks/scripts/flash_image.sh	Modified FLASH_CMD defaulting logic to differentiate between explicitly empty and unset variables, changing when the default value is applied.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix: add oci:// prefix to default flash command and preserve flashCmd #226: Modifies the same FLASH_CMD initialization and handling in flash_image.sh, including preservation of user-supplied flash commands.
• support command chaining for --flash-cmd #153: Changes how FLASH_CMD is executed in the same script by wrapping it with shell command chaining.

Suggested reviewers

• bkhizgiy

Poem

🐰 A variable's fate, now clear and bright,
Empty or unset? Each gets its right!
The defaults dance in perfect time,
No more ambiguous—the logic's sublime! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix flash cmd rendering' accurately describes the main change: fixing how the FLASH_CMD variable is being rendered/interpolated in the flash_image.sh script.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 0/1 reviews remaining, refill in 60 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}