This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Use shorter key names for log correlation (issue #195). #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on#195). This commit removes the "openCensus" prefix from all key names in the log correlation spec. The shorter key names are simpler and could improve performance when the keys are included in the logs.
yurishkuro
approved these changes
Oct 12, 2018
| @@ -54,5 +54,5 @@ and format the sampling decision as "true" or "false". | |||
|
|
|||
| Some logging frameworks allow the insertion of arbitrary key-value pairs into log entries. When | |||
| a log correlation implementation inserts tracing data by that method, the key names should be | |||
| "opencensusTraceId", "opencensusSpanId", and "opencensusTraceSampled" by default. The log | |||
| correlation implementation may allow the user to override the tracing data key names. | |||
| "traceId", "spanId", and "traceSampled" by default. The log correlation implementation may allow | |||
There was a problem hiding this comment.
probably a good name for traceSampled.. I've seen "sampled" but no strong feelings.
codefromthecrypt
approved these changes
Oct 12, 2018
bogdandrutu
approved these changes
Oct 12, 2018
rakyll
approved these changes
Oct 12, 2018
g-easy
approved these changes
Oct 12, 2018
trace/LogCorrelation.md
Outdated
| "opencensusTraceId", "opencensusSpanId", and "opencensusTraceSampled" by default. The log | ||
| correlation implementation may allow the user to override the tracing data key names. | ||
| "traceId", "spanId", and "traceSampled" by default. The log correlation implementation may allow | ||
| the user to override the tracing data key names. |
There was a problem hiding this comment.
Optional: "override the key names"
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the "openCensus" prefix from all key names in the log
correlation spec. The shorter key names are simpler and could improve
performance when the keys are included in the logs.
/cc @yurishkuro @rakyll @Ramonza @SergeyKanzhelev