Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release for v0.7.7 #853

Merged
merged 6 commits into from
Feb 3, 2020
Merged

Release for v0.7.7 #853

merged 6 commits into from
Feb 3, 2020

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Feb 3, 2020

Minor release. Consists of mostly azure related changes.

Trace span attribute changes: [#827]
Log Exporter custom dimension API changes: [#837]
Local storage + retry for metrics exporter: [#845]
Fixed rate sampling for log exporter: [#848]
Telemetry processors for exporters: [#851]

@lzchen lzchen requested a review from c24t February 3, 2020 20:19
@lzchen lzchen requested review from reyang, songy23 and a team as code owners February 3, 2020 20:19
c24t
c24t approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the minimum required opencensus version for opencensus-ext-httplib and opencensus-ext-requests?

Look good otherwise.

CHANGELOG.md
@@ -2,6 +2,14 @@

## Unreleased

## 0.7.7
Released 2020-02-03
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Released 2020-02-03
Released 2020-02-03

CHANGELOG.md
@@ -2,6 +2,14 @@

## Unreleased

## 0.7.7
Released 2020-02-03
- Update `azure` module
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Update `azure` module
- Updated `azure` module

To be consistent with the others

@lzchen
Copy link
Contributor Author

lzchen commented Feb 3, 2020 •
edited
Loading

Do we need to update the minimum required opencensus version for opencensus-ext-httplib and opencensus-ext-requests?

Look good otherwise.

@c24t
Correct if if I'm wrong, but don't we need to update the minimum required version of opencensus only if there were new changes in opencensus that opencensus-ext-httplib and opencensus-ext-requests would rely on?

@c24t
Copy link
Member

c24t commented Feb 3, 2020

You're right, I see that these changes just add some new span attributes in the ext packages.

You might want to change the message in the changelog though. "Support span attribute changes in opencensus>=0.7.7" makes it sound like the ext libraries were changed to support attribute changes in the core library.

@lzchen lzchen merged commit 72f2363 into census-instrumentation:v0.7.x Feb 3, 2020
@lzchen lzchen deleted the release branch February 3, 2020 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c24t c24t c24t approved these changes

@reyang reyang Awaiting requested review from reyang

@songy23 songy23 Awaiting requested review from songy23

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lzchen @c24t @googlebot