Skip to content

Fix Celo maxFeePerGas calculation for fee currency transactions.#19

Merged
shazarre merged 2 commits intomainfrom
shazarre/Celo_multiply_base_fee
Oct 3, 2024
Merged

Fix Celo maxFeePerGas calculation for fee currency transactions.#19
shazarre merged 2 commits intomainfrom
shazarre/Celo_multiply_base_fee

Conversation

@shazarre
Copy link

@shazarre shazarre commented Sep 30, 2024

Previously we were not applying multiply function to the base fee returned from the node. This PR fixes that.

@shazarre shazarre self-assigned this Sep 30, 2024
@github-actions
Copy link

github-actions bot commented Sep 30, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
import * from 'viem' (esm) 61 KB (0%) 1.3 s (0%) 7.9 s (-5.42% 🔽) 9.1 s
const viem = require('viem') (cjs) 71.19 KB (0%) 1.5 s (0%) 12.7 s (+203.06% 🔺) 14.2 s
import { createClient, http } from 'viem' 6.26 KB (0%) 126 ms (0%) 941 ms (+57.36% 🔺) 1.1 s
import * from 'viem/account-abstraction' 43.9 KB (0%) 879 ms (0%) 7.4 s (-8.72% 🔽) 8.3 s
import { toCoinbaseSmartAccount } from 'viem/account-abstraction' 34.07 KB (0%) 682 ms (0%) 2.6 s (-50.01% 🔽) 3.3 s
import * from 'viem/accounts' 80.9 KB (0%) 1.7 s (0%) 5.4 s (+39.78% 🔺) 7 s
import { privateKeyToAccount } from 'viem/accounts' 19.41 KB (0%) 389 ms (0%) 1.3 s (-45.73% 🔽) 1.7 s
import { mnemonicToAccount } from 'viem/accounts' 25.69 KB (0%) 514 ms (0%) 2.6 s (-14.82% 🔽) 3.1 s
import * from 'viem/actions' 46.05 KB (0%) 922 ms (0%) 7.2 s (-17.32% 🔽) 8.1 s
import { getBlockNumber } from 'viem/actions' 318 B (0%) 10 ms (0%) 38 ms (-68.25% 🔽) 48 ms
import * from 'viem/chains' 38.41 KB (+0.03% 🔺) 769 ms (+0.03% 🔺) 6.2 s (-17.74% 🔽) 6.9 s
import { mainnet } from 'viem/chains' 324 B (0%) 10 ms (0%) 144 ms (+49.39% 🔺) 154 ms
import * from 'viem/chains/utils' 1.08 KB (0%) 22 ms (0%) 165 ms (-86.03% 🔽) 187 ms
import * from 'viem/ens' 45.49 KB (0%) 910 ms (0%) 7 s (+13.81% 🔺) 8 s
import { getEnsAvatar } from 'viem/ens' 22.18 KB (0%) 444 ms (0%) 4 s (-5.43% 🔽) 4.4 s
import * from 'viem/siwe' 30.26 KB (0%) 606 ms (0%) 2.7 s (-41.51% 🔽) 3.3 s
import { verifySiweMessage } from 'viem/siwe' 29.19 KB (-0.17% 🔽) 584 ms (-0.17% 🔽) 7 s (+68.58% 🔺) 7.5 s

@shazarre shazarre changed the title Celo: multiply base fee Fix Celo maxFeePerGas calculation for fee currency transactions. Sep 30, 2024
@shazarre shazarre force-pushed the shazarre/Celo_multiply_base_fee branch from d75ff53 to 92e65fd Compare September 30, 2024 12:36
@shazarre shazarre marked this pull request as ready for review September 30, 2024 12:37
@aaronmgdr
Copy link

open against wevm/main

Copy link

@nicolasbrugneaux nicolasbrugneaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@aaronmgdr
Copy link

@shazarre shazarre merged commit 471a3f8 into main Oct 3, 2024
piersy pushed a commit that referenced this pull request Dec 12, 2024
…m#2811)

Fix Celo maxFeePerGas calculation for fee currency transactions. (#19)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments