Skip to content

Conversation

@palango
Copy link

@palango palango commented Sep 27, 2023

Adds the FeeCurrencyWhitelist contract, part of #57.

@pahor167 Please have a look at this. The changes I did:

  • Add the license modifier
  • Update solidity pragma
  • Fix imports
  • Removed the public visibility modifier from the constructor, because solc complained.

@palango palango requested a review from pahor167 September 27, 2023 15:58
@palango
Copy link
Author

palango commented Sep 28, 2023

Mhg, I'm not sure why this complains about the ABIs. I'm using the abigen version that is required:

% abigen --version
abigen version 1.10.25-stable

@pahor167
Copy link

pahor167 commented Oct 3, 2023

Mhg, I'm not sure why this complains about the ABIs. I'm using the abigen version that is required:

% abigen --version
abigen version 1.10.25-stable

Did you run make in op-bindings folder after all changes to smart contract were done ? I took the liberty to fetch branch, rebuild bindings and it seems that op-bindings-build is passing.

abigen --version abigen version 1.10.25-stable

My abigen version is same as yours.

Predeploys["GoldToken"] = &GoldTokenAddr
Predeploys["FeeCurrencyWhitelist"] = &FeeCurrencyWhitelistAddr

CeloPredeploys[Predeploys["CeloRegistry"].String()] = Predeploys["CeloRegistry"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is necessary to also add FeeCurrencyWhitelist into CeloPredeploys

@palango
Copy link
Author

palango commented Oct 13, 2023

This is included in #70

@palango palango closed this Oct 13, 2023
@palango palango deleted the palango/add-fee-curr-contracts branch June 28, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants