Conversation
Author
|
I have no idea why "ci/circleci: op-e2e-HTTP-tests" fails three times in a row but succeeded before this PR. |
palango
approved these changes
Sep 27, 2023
carterqw2
reviewed
Sep 27, 2023
op-e2e/celo/devnet-token_duality.sh
Outdated
Comment on lines
4
to
8
| export ETH_RPC_URL=http://127.0.0.1:9545 | ||
| ACC_PRIVKEY=ac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80 | ||
| ACC_ADDR=$(cast wallet address $ACC_PRIVKEY) | ||
|
|
||
| REGISTRY_ADDR=0x000000000000000000000000000000000000ce10 |
Author
There was a problem hiding this comment.
Yes, which is done in op-e2e/celo/test_token_duality.sh. This file just should not have been included in the PR, as it was my initial try of getting token duality to work with the devnet. All the relevant parts are in op-e2e/celo/test_token_duality.sh, so I'll just remove it.
karlb
force-pushed
the
karlb/e2e-test
branch
from
b046a44 to
60bc52a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on celo-org/op-geth#21
See https://app.circleci.com/pipelines/github/celo-org/optimism/398/workflows/b5aac39e-5035-47bb-86d1-3c2151ca3cc4/jobs/5132/parallel-runs/0/steps/0-114 for CI results.