OptimismPortal2 set initial _balance through StorageSetter pattern
#254
+52
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #239 The custom gas-token feature adaptation for the fault-proof system using the `OptimismPortal2` contract has been merged recently upstream. We are using the custom-gas-token feature and additionally require a modification of the OptimismPortal's `_balance` value to be set to the entire allocation of Celo on the L2 - meaning that all L1 token is initially locked in the bridge and only usable on the L2. Those changes are now adapted also to the `OptimismPortal2`, which was a requirement to make our custom-gas-token pre-locked balance feature work in conjunction with fault-proofs.
carterqw2
reviewed
Oct 9, 2024
| @@ -412,7 +423,13 @@ library ChainAssertions { | |||
| } | |||
| // This slot is the custom gas token _balance and this check ensures | |||
| // that it stays unset for forwards compatibility with custom gas token. | |||
| require(vm.load(address(portal), bytes32(uint256(61))) == bytes32(0)); | |||
| // if we use the pre-locked storage modification, the comprison | |||
There was a problem hiding this comment.
Suggested change
| // if we use the pre-locked storage modification, the comprison | |
| // if we use the pre-locked storage modification, the comparison |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #239
The custom gas-token feature adaptation for the fault-proof system using the
OptimismPortal2contract has been merged recently upstream.We are using the custom-gas-token feature and additionally require a modification of the OptimismPortal's
_balancevalue to be set to the entire allocation of Celo on the L2 - meaning that all L1 token is initially locked in the bridge and only usable on the L2.Those changes are now adapted also to the
OptimismPortal2, which was a requirement to make our custom-gas-token pre-locked balance feature work in conjunction with fault-proofs.