Block data migration #147
Closed
Block data migration #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alec Schaefer <alecps@users.noreply.github.com>
…/minimal-data-migration
Co-authored-by: Mariano Cortesi <mcortesi@gmail.com>
Removes unused code, move code for better separation of concerns.
alecps
force-pushed
the
block-data-migration
branch
from
00e09d8 to
f72af10
Compare
alecps
commented
Jun 12, 2024
| name: Docker Build Scan | ||
| on: | ||
| pull_request: | ||
| branches: |
piersy
reviewed
Jun 13, 2024
Comment on lines
+229
to
232
| // replace github.com/ethereum/go-ethereum => github.com/celo-org/op-geth v0.0.0-20240612131021-96a2a76ceaaa | ||
| replace github.com/ethereum/go-ethereum => github.com/celo-org/op-geth v0.0.0-20240612164035-ef9b9a19f53e | ||
|
|
||
| //replace github.com/ethereum/go-ethereum v1.13.9 => ../op-geth |
There was a problem hiding this comment.
Suggested change
| // replace github.com/ethereum/go-ethereum => github.com/celo-org/op-geth v0.0.0-20240612131021-96a2a76ceaaa | |
| replace github.com/ethereum/go-ethereum => github.com/celo-org/op-geth v0.0.0-20240612164035-ef9b9a19f53e | |
| //replace github.com/ethereum/go-ethereum v1.13.9 => ../op-geth | |
| replace github.com/ethereum/go-ethereum => github.com/celo-org/op-geth v0.0.0-20240612164035-ef9b9a19f53e |
piersy
reviewed
Jun 13, 2024
|
|
||
| replace github.com/ethereum/go-ethereum => github.com/celo-org/op-geth v0.0.0-20240612131021-96a2a76ceaaa | ||
| // replace github.com/ethereum/go-ethereum => github.com/celo-org/op-geth v0.0.0-20240612131021-96a2a76ceaaa | ||
| replace github.com/ethereum/go-ethereum => github.com/celo-org/op-geth v0.0.0-20240612164035-ef9b9a19f53e |
There was a problem hiding this comment.
Note that we'll need to wait for my branch to be merged before you can merge this PR and after my branch has been merged you'll need to update this reference.
piersy
reviewed
Jun 13, 2024
piersy
reviewed
Jun 13, 2024
piersy
reviewed
Jun 13, 2024
piersy
reviewed
Jun 13, 2024
|
A couple of little points but looks fine, just we'll need to wait for PRs for support for migrated types to get merged into celo6 before we can merge this! |
Author
|
Closing in favor of #148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #121 over to celo6