Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forkdiff comparison to op-geth #7

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Add forkdiff comparison to op-geth #7

merged 4 commits into from
Aug 22, 2023

Conversation

eelanagaraj
Copy link

@eelanagaraj eelanagaraj commented Aug 18, 2023 •
edited
Loading

Description

Add forkdiff comparison between celo's & OP's op-geth repos. The structure has been left intentionally very simple for now. Ideally, as new Celo features are added, we can also update the forkdiff output to properly visualize these new features.

Take a look at the deployed version: https://celo-org.github.io/op-geth/

Note: this currently points to a slightly older OP commit than we have merged in order to sanity check the diffs, but this will be updated.

Other than the code changes, as part of this PR, the GH pages build (from gh-pages branch) & workflows have been activated

TODOs (after review, any structure changes)

  • update hash to point to the latest OP commit hash in our history
  • remove trigger for pushes to eelanagaraj/add-forkdiff
  • add comment to token duality ticket & remove TODOs

Related issues

#6

@eelanagaraj eelanagaraj linked an issue Aug 18, 2023 that may be closed by this pull request
Set up forkdiff for op-geth #6
Closed
@eelanagaraj eelanagaraj changed the title Add forkdiff comparison between op-geth and celo's op-geth Add forkdiff comparison to op-geth Aug 18, 2023
palango
palango approved these changes Aug 18, 2023
View reviewed changes
Copy link

@palango palango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@eelanagaraj eelanagaraj changed the base branch from optimism to celo1 August 21, 2023 10:44
@eelanagaraj eelanagaraj merged commit 9b54249 into celo1 Aug 22, 2023
1 of 2 checks passed
@eelanagaraj eelanagaraj deleted the eelanagaraj/add-forkdiff branch August 22, 2023 13:24
palango pushed a commit that referenced this pull request Sep 26, 2023
@palango
Add forkdiff comparison to op-geth (#7)
c5c3c9e 
* Add forkdiff comparison between op-geth and celo's op-geth

* Remove TODOs

* Update trigger to reflect future celo default branch pattern

* Update latest rebased commit
karlb pushed a commit that referenced this pull request Nov 17, 2023
@karlb
Add forkdiff comparison to op-geth (#7)
cb644d0 
* Add forkdiff comparison between op-geth and celo's op-geth

* Remove TODOs

* Update trigger to reflect future celo default branch pattern

* Update latest rebased commit
palango pushed a commit that referenced this pull request Jan 31, 2024
@palango
Add forkdiff comparison to op-geth (#7)
1f7d646 
* Add forkdiff comparison between op-geth and celo's op-geth

* Remove TODOs

* Update trigger to reflect future celo default branch pattern

* Update latest rebased commit
palango pushed a commit that referenced this pull request Jan 31, 2024
@palango
Add forkdiff comparison to op-geth (#7)
5b4a5be 
* Add forkdiff comparison between op-geth and celo's op-geth

* Remove TODOs

* Update trigger to reflect future celo default branch pattern

* Update latest rebased commit
karlb pushed a commit that referenced this pull request Feb 20, 2024
@karlb
Add forkdiff comparison to op-geth (#7)
726cc0e 
* Add forkdiff comparison between op-geth and celo's op-geth

* Remove TODOs

* Update trigger to reflect future celo default branch pattern

* Update latest rebased commit
karlb pushed a commit that referenced this pull request Feb 20, 2024
@karlb
Add forkdiff comparison to op-geth (#7)
0a0ad9e 
* Add forkdiff comparison between op-geth and celo's op-geth

* Remove TODOs

* Update trigger to reflect future celo default branch pattern

* Update latest rebased commit
palango pushed a commit that referenced this pull request Apr 30, 2024
@palango
Add forkdiff comparison to op-geth (#7)
d822474 
* Add forkdiff comparison between op-geth and celo's op-geth

* Remove TODOs

* Update trigger to reflect future celo default branch pattern

* Update latest rebased commit
palango pushed a commit that referenced this pull request Apr 30, 2024
@palango
Add forkdiff comparison to op-geth (#7)
5390573 
* Add forkdiff comparison between op-geth and celo's op-geth

* Remove TODOs

* Update trigger to reflect future celo default branch pattern

* Update latest rebased commit
palango pushed a commit that referenced this pull request Apr 30, 2024
@palango
Add forkdiff comparison to op-geth (#7)
0769873 
* Add forkdiff comparison between op-geth and celo's op-geth

* Remove TODOs

* Update trigger to reflect future celo default branch pattern

* Update latest rebased commit
palango pushed a commit that referenced this pull request May 8, 2024
@palango
Add forkdiff comparison to op-geth (#7)
21bd99d 
* Add forkdiff comparison between op-geth and celo's op-geth

* Update trigger to reflect future celo default branch pattern

* Update latest rebased commit
palango pushed a commit that referenced this pull request May 31, 2024
@palango
Add forkdiff comparison to op-geth (#7)
4b870b2 
* Add forkdiff comparison between op-geth and celo's op-geth

* Update trigger to reflect future celo default branch pattern

* Update latest rebased commit
carterqw2 pushed a commit that referenced this pull request Jun 11, 2024
@carterqw2
Add forkdiff comparison to op-geth (#7)
dc1a530 
* Add forkdiff comparison between op-geth and celo's op-geth

* Update trigger to reflect future celo default branch pattern

* Update latest rebased commit
karlb pushed a commit that referenced this pull request Jul 10, 2024
@karlb
Add forkdiff comparison to op-geth (#7)
e27cdce 
* Add forkdiff comparison between op-geth and celo's op-geth

* Update trigger to reflect future celo default branch pattern

* Update latest rebased commit
karlb pushed a commit that referenced this pull request Jul 10, 2024
@karlb
Add forkdiff comparison to op-geth (#7)
e711bb5 
* Add forkdiff comparison between op-geth and celo's op-geth

* Update trigger to reflect future celo default branch pattern

* Update latest rebased commit
karlb pushed a commit that referenced this pull request Jul 12, 2024
@karlb
Add forkdiff comparison to op-geth (#7)
9892946 
* Add forkdiff comparison between op-geth and celo's op-geth

* Update trigger to reflect future celo default branch pattern

* Update latest rebased commit
karlb pushed a commit that referenced this pull request Aug 20, 2024
@karlb
Add forkdiff comparison to op-geth (#7)
e6e1520 
* Add forkdiff comparison between op-geth and celo's op-geth

* Update trigger to reflect future celo default branch pattern

* Update latest rebased commit
karlb pushed a commit that referenced this pull request Aug 26, 2024
@karlb
Add forkdiff comparison to op-geth (#7)
f6f60e8 
* Add forkdiff comparison between op-geth and celo's op-geth

* Update trigger to reflect future celo default branch pattern

* Update latest rebased commit
karlb pushed a commit that referenced this pull request Aug 30, 2024
@karlb
Add forkdiff comparison to op-geth (#7)
322cdb7 
* Add forkdiff comparison between op-geth and celo's op-geth

* Update trigger to reflect future celo default branch pattern

* Update latest rebased commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palango palango palango approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up forkdiff for op-geth
2 participants
@eelanagaraj @palango