Use Celo Sepolia for e2e test instead of alfajores#428
Merged
karlb merged 2 commits intocelo-rebase-14from Sep 10, 2025
Merged
Conversation
karlb
force-pushed
the
karlb/use-sepolia-for-e2e
branch
from
761598a to
a14574e
Compare
Is this expected? Shouldn't we run this on some fixed schedule? |
palango
approved these changes
Aug 21, 2025
palango
left a comment
palango
left a comment
There was a problem hiding this comment.
Looks good, left one comment, but feel free to ignore.
The changed error message is more precise and more stable across geth versions. Right now, the test "zero tip fee currency tx rejected" still fails for Sepolia, but the same is true for Alfajores. It will work once the node is updated. Closes celo-org/celo-blockchain-planning#1158
This brings a celoSepolia definition and staying up to date is generally a good idea. Due to wevm/viem#3117 being merged in view, we can (and have to) remove a changed assert in the "test gas price difference for fee currency" test.
karlb
force-pushed
the
karlb/use-sepolia-for-e2e
branch
from
a14574e to
32ffa2e
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
|
@SocketSecurity ignore-all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changed error message is more precise and more stable across geth versions.
Right now, the test "zero tip fee currency tx rejected" still fails for Sepolia, but the same is true for Alfajores. It will work once the node is updated. It is only run in CI when e2e test files are changed, so merging it in this state won't be too annoying.
Closes https://github.com/celo-org/celo-blockchain-planning/issues/1158