Conversation
Is there any real choice but not to include txs with that fee currency? |
2673d28 to
5d0e2d4
Compare
I'm asking because this is not what we currently do: https://github.com/celo-org/celo-blockchain/blob/d2e7c9f3a44a727a8117da9c928a3ccb8e582f27/contracts/currency/currency.go#L206 But this behaviour doesn't make sense to me either and I think we should avoid those transactions. |
|
Maybe the "IsWhitelisted" should be something like "IsAvailable", and if we cannot find the exchange rate OR if it's not whitelisted, we should drop all txs |
It behaves like that now. But I still think |
Add tests Rebase tmp Add error PR review CHanges after discussion
db92f42 to
c7f30a9
Compare
|
Included in #43 |
Resolves #72
Adds a new
CeloContextas described in #72. Will need changes after #26 .Open questions
What should we do if a fee currency is whitelisted but we cannot get an exchange rate?BlockContext?